Opened 10 years ago
Last modified 8 years ago
#12459 review Bug
Exception occurs after using Replace All and closing Find and Replace dialog in IE11
Reported by: | Aliaksei | Owned by: | kkrzton |
---|---|---|---|
Priority: | Nice to have (we want to work on it) | Milestone: | |
Component: | General | Version: | 4.0 |
Keywords: | IE | Cc: | rick.schnorenberg@… |
Description
When i use Replace all feature and close the replace all dialog after that, an exception occurs in IE11.
Environment: OS:Windows 7 x64 Browser: Internet Explorer 11.0.9600.17280 (Update 11.0.12)
Reproducible on demo page: http://ckeditor.com/demo#full
Steps:
- Remove all sample text and images from the CKEditor on the demo page.
- Type the following text: test text number 1
- Press Replace button on the toolbar
- In the Find what field type the following text: number
- In the Replace with field type the following text: N
- Press Replace All button
- Press OK button on the notification Message Box
- Press close button on the Find and Replace dialog
- Look in the browser console for the error.
Screen shot is attached.
Attachments (1)
Change History (17)
Changed 10 years ago by
Attachment: | CKEditor Exception.png added |
---|
comment:1 Changed 10 years ago by
Keywords: | IE added |
---|---|
Status: | new → confirmed |
Version: | 4.4.4 → 4.0 |
I was able to reproduce this problem in IE9-11 from CKEditor 4.0 (doesn't occur in 4.0 beta).
Error that gets throw is:
Message: SCRIPT5022: IndexSizeError
Line: 1963
URI: selection.js
Similar issues where IndexSizeError was reported are: #12026, #10411. Issues where selection.js error in similar area is : #12212
Similar issues where IndexSizeError and selection.js was reported are: #10858, #12152.
comment:2 Changed 10 years ago by
Cc: | rick.schnorenberg@… added |
---|
comment:3 Changed 9 years ago by
Milestone: | → CKEditor 4.5.7 |
---|
comment:4 Changed 9 years ago by
Owner: | set to kkrzton |
---|---|
Status: | confirmed → assigned |
comment:5 Changed 9 years ago by
Basically when replace dialog is opened in IE, IE loses focus (blur event) so it uses lock selection to save selection range. After replacing the text (with shorter text), the saved ranges are out of date and start/end offset are out of bounds. The error occurs after closing dialog when the selection restoring mechanism tries to restore selection based on outdated ranges.
comment:6 Changed 9 years ago by
Status: | assigned → review |
---|
comment:7 Changed 9 years ago by
Status: | review → review_failed |
---|
- TCs can be joined into one file, as there are just two very similar cases.
- TCs are not about wysiwygarea or toolbar plugin (as the tags state) – they are about find plugin and selection. If we are going to put all plugins also as tags, then 95% of our tests would be connected to toolbar plugin ;)
- I'm not sure, but I'd move manual tests to other tests for find plugin.
- It would be nice if we have also unit test(s) for it – mainly because it touches selection.
comment:8 Changed 9 years ago by
Status: | review_failed → assigned |
---|
comment:9 Changed 9 years ago by
Status: | assigned → review |
---|
Changes in t/12459.
- Manual TCs were merged into one file and moved to find plugin tests dir.
- Tags for TCs were fixed.
- Two unit tests were added.
comment:10 Changed 9 years ago by
Milestone: | CKEditor 4.5.7 → CKEditor 4.5.8 |
---|
comment:11 Changed 9 years ago by
Milestone: | CKEditor 4.5.8 → CKEditor 4.5.9 |
---|
comment:12 Changed 9 years ago by
Milestone: | CKEditor 4.5.9 → CKEditor 4.5.10 |
---|
comment:13 Changed 8 years ago by
Milestone: | CKEditor 4.5.10 → CKEditor 4.5.11 |
---|
Moving tickets to the next milestone.
comment:14 Changed 8 years ago by
Milestone: | CKEditor 4.5.11 → CKEditor 4.6.1 |
---|
comment:15 Changed 8 years ago by
Milestone: | CKEditor 4.6.1 → CKEditor 4.6.2 |
---|
Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.
comment:16 Changed 8 years ago by
Milestone: | CKEditor 4.6.2 |
---|---|
Priority: | Normal → Nice to have (we want to work on it) |
Moving to the nice to have list.
Exception