Opened 5 years ago

Last modified 2 years ago

#12459 review Bug

Exception occurs after using Replace All and closing Find and Replace dialog in IE11

Reported by: Aliaksei Owned by: kkrzton
Priority: Nice to have (we want to work on it) Milestone:
Component: General Version: 4.0
Keywords: IE Cc: rick.schnorenberg@…

Description

When i use Replace all feature and close the replace all dialog after that, an exception occurs in IE11.

Environment: OS:Windows 7 x64 Browser: Internet Explorer 11.0.9600.17280 (Update 11.0.12)

Reproducible on demo page: http://ckeditor.com/demo#full

Steps:

  1. Remove all sample text and images from the CKEditor on the demo page.
  2. Type the following text: test text number 1
  3. Press Replace button on the toolbar
  4. In the Find what field type the following text: number
  5. In the Replace with field type the following text: N
  6. Press Replace All button
  7. Press OK button on the notification Message Box
  8. Press close button on the Find and Replace dialog
  9. Look in the browser console for the error.

Screen shot is attached.

Attachments (1)

CKEditor Exception.png (99.7 KB) - added by Aliaksei 5 years ago.
Exception

Download all attachments as: .zip

Change History (17)

Changed 5 years ago by Aliaksei

Attachment: CKEditor Exception.png added

Exception

comment:1 Changed 5 years ago by Jakub Ś

Keywords: IE added
Status: newconfirmed
Version: 4.4.44.0

I was able to reproduce this problem in IE9-11 from CKEditor 4.0 (doesn't occur in 4.0 beta).

Error that gets throw is:
Message: SCRIPT5022: IndexSizeError
Line: 1963
URI: selection.js

Similar issues where IndexSizeError was reported are: #12026, #10411. Issues where selection.js error in similar area is : #12212

Similar issues where IndexSizeError and selection.js was reported are: #10858, #12152.

comment:2 Changed 4 years ago by Rick Schnorenberg

Cc: rick.schnorenberg@… added

comment:3 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.7

comment:4 Changed 3 years ago by kkrzton

Owner: set to kkrzton
Status: confirmedassigned

comment:5 Changed 3 years ago by kkrzton

Basically when replace dialog is opened in IE, IE loses focus (blur event) so it uses lock selection to save selection range. After replacing the text (with shorter text), the saved ranges are out of date and start/end offset are out of bounds. The error occurs after closing dialog when the selection restoring mechanism tries to restore selection based on outdated ranges.

comment:6 Changed 3 years ago by kkrzton

Status: assignedreview

Changes in t/12459.

There is also a broader issue with selection restoring #14337.

comment:7 Changed 3 years ago by Tomasz Jakut

Status: reviewreview_failed
  • TCs can be joined into one file, as there are just two very similar cases.
  • TCs are not about wysiwygarea or toolbar plugin (as the tags state) – they are about find plugin and selection. If we are going to put all plugins also as tags, then 95% of our tests would be connected to toolbar plugin ;)
  • I'm not sure, but I'd move manual tests to other tests for find plugin.
  • It would be nice if we have also unit test(s) for it – mainly because it touches selection.

comment:8 Changed 3 years ago by kkrzton

Status: review_failedassigned

comment:9 Changed 3 years ago by kkrzton

Status: assignedreview

Changes in t/12459.

  • Manual TCs were merged into one file and moved to find plugin tests dir.
  • Tags for TCs were fixed.
  • Two unit tests were added.

comment:10 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.7CKEditor 4.5.8

comment:11 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.8CKEditor 4.5.9

comment:12 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.9CKEditor 4.5.10

comment:13 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.10CKEditor 4.5.11

Moving tickets to the next milestone.

comment:14 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.11CKEditor 4.6.1

comment:15 Changed 2 years ago by Marek Lewandowski

Milestone: CKEditor 4.6.1CKEditor 4.6.2

Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.

comment:16 Changed 2 years ago by Marek Lewandowski

Milestone: CKEditor 4.6.2
Priority: NormalNice to have (we want to work on it)

Moving to the nice to have list.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy