Error in console after removing formatting and disabling selection as a list item.

[Artur Delura]

Browsers: Chrome, FF and IE9+

1. Open editor with following content and selection:

   <ol>
   	<li>hello</li>
   	<li>moto</li>
   	<li><strong>[:D]</strong></li>
   </ol>
   

2. Click "Remove format" button.
3. Press "Ordered List" or "Unordered List" button.

Actual result:

There is an error in console: TypeError: node is null range.js:1724

this.setStart( node.getParent(), node.getIndex() );

[Jakub Ś]

I was able to reproduce this problem from CKEditor 3.0 in every browser except IE8.

[kkrzton]

For html like this (with :D selected):

<ol>
    <li>hello</li>
    <li>moto</li>
    <li>:D</li>
</ol>

During element manipulation (e.g. list/unlist) selection is bookmarked as follows:

<ol>
    <li>hello</li>
    <li>moto</li>
    <li><span id="cke_bm_204S" style="display:none">&nbsp;</span>:D<span id="cke_bm_204E" style="display:none">&nbsp;</span></li>
</ol>

so the bookmarks are inside li element.

When applying remove format to the above selection, bookmarks are moved outside li element:

<ol>
    <li>hello</li>
    <li>moto</li>
    <span data-cke-bookmark="1" style="display: none;">&nbsp;</span>
    <li>:D</li>
</ol>
<span data-cke-bookmark="1" style="display: none;">&nbsp;</span>

and so it breaks further processing.

[kkrzton]

This issue does not occur in IE8.

[kkrzton]

Changes in ​t/12480.

This fix adds range clone on which removing format is processed (nothing changes in the process itself). The range clone is enlarged during the process which is the cause of change in placement of selection bookmarks (as mentioned in earlier comment). The original range is shrinked so its start and end containers points to selected text (and not the containing nodes which may be removed by removeformat).

Selection is restored based on original range which assures it contains as little additional elements as possible. There is one exception for containers with conteneteditable elements which should use enlarged range for selection restoring.

[Marek Lewandowski]

Moving tickets to the next milestone.

[Marek Lewandowski]

Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.

[Marek Lewandowski]

Moving to the nice to have list.