Opened 5 years ago

Closed 5 years ago

#12664 closed Bug (expired)

Code Snippet: Codesnippet instance will insert the code block at the beginning of the editor

Reported by: Anna Tomanek Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

Reported as a comment on the addon's site: http://ckeditor.com/comment/135211#comment-135211

I have a particular bug I'm trying to address, I've just upgraded CKEditor to 4.4.5 mainly to address the Safari 7.1 bug. However, prior to the 4.4.5 release, and now with the latest version, my codesnippet instance will insert the code block at the beginning of the editor occasionally. I get a console error from the main Widget plugin's plugin.js file after clicking "Ok" from the dialog.

Uncaught TypeError: Cannot set property 'ready' of null

and the offender:

finalizeCreation: function( container ) {
	var wrapper = container.getFirst();
	if ( wrapper && isDomWidgetWrapper( wrapper ) ) {
		this.editor.insertElement( wrapper );

		var widget = this.getByElement( wrapper );
		// Fire postponed #ready event.
		widget.ready = true; // I'm raising the error above
		widget.fire( 'ready' );
		widget.focus();
	}
},

The line:

var widget = this.getByElement( wrapper );

Seems like it's not finding the widget by the element.

I'm trying to find a detailed changlog for this plugin specifically, to determine my upgrade procedure, what were the specific changes to this plugin for 4.4.5? Any thoughts on what may be causing this bug?

Change History (2)

comment:1 Changed 5 years ago by Piotrek Koszuliński

Status: newpending
Version: 4.4.5

Unfortunately that's not enough information. To work on this issue we need to be able to reproduce it.

  • On what browser does it happen?
  • Could you tell us more about when does it happen and how can we reproduce that?
  • If it's a totally random thing please record a screencast and/or paste here the result of executing editor.editable().getData().
  • Stack trace could help too.

PS. You wrote that this issue occurs prior to the 4.4.5, so why do you ask what has changed in 4.4.5? Anyway - the answer is that nothing strongly related to widgets.

comment:2 Changed 5 years ago by Jakub Ś

Resolution: expired
Status: pendingclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy