Opened 4 years ago

Last modified 4 years ago

#12716 confirmed New Feature

TableTools should be made available from toolbar when context menu isn't used.

Reported by: Jakub Ś Owned by:
Priority: Normal Milestone:
Component: General Version: 4.0
Keywords: Cc:

Description

We have made a fix in #9284 but now users can't use tabletools if they don't want to use contextmenu plugin.

We could make tabletools available from toolbar but first we need to fix: http://dev.ckeditor.com/ticket/7903.

Change History (6)

comment:1 Changed 4 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 4 years ago by Danil

Looks like moving menu items from context menu to the toolbar menu discovers another issues: http://jsfiddle.net/danya_postfactum/gwragLhw/

  1. Disabled menu item does not disable it's children subitems.
  2. Items, associated with commands, are completely hidden from menu when you are not in a table.
Last edited 4 years ago by Jakub Ś (previous) (diff)

comment:3 Changed 4 years ago by Jakub Ś

Thank you for checking this one. Please note however that we first need to fix #7903.

  1. This is indeed a problem and should be fixed.
  2. Yes, elements should be disabled instead of being hidden.

If possible please don't remove this fiddle or please attach your sample code to this ticket for future reference.

comment:4 Changed 4 years ago by Jakub Ś

Second issue was described in #12723.

comment:5 Changed 4 years ago by Danil

  1. How should it work? I guess this way:
if ( editor.contextMenu ) {
    // Add context menu items
} else {
    // add toolbar button
}

Right?

  1. We need icons. At least one icon for toolbar button. Can we ask moono designer about it?

comment:6 Changed 4 years ago by Piotrek Koszuliński

  1. How should it work? I guess this way:

The right way would be to first solve #7903 to have a public API. Then extracting part of tabletools which creates the context menu options to a separate plugin (e.g. tabletoolscontextmenu). And then creating new plugin tabletoolsbutton. This way everyone will be able to choose which option she/he prefers. For example, one may want to use the contextmenu plugin, but still move the table tools from the context menu to the toolbar.

  1. We need icons. At least one icon for toolbar button. Can we ask moono designer about it?

The moono's icons author is available, so as soon as there's something to work on, we can ask him.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy