Opened 5 years ago

Last modified 5 years ago

#12723 confirmed Bug

Menu plugin hides disabled command-assigned items

Reported by: Danil Owned by:
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: Cc:

Description

Currently, "menu" plugin skips menu items, associated with commands, having disabled state. This behavior is good for context menus. But "menu" plugin is "abstract", it's also used for toolbar menus, where this behavior is not desired.

See demo: http://jsfiddle.net/danya_postfactum/gwragLhw/ See table tools button. It should have "Delete table" and "Table properties". But these items are displayed when cursor in table context only.

It's easy to fix, because this feature is not used, except "table" and "clipboard" plugins. Other plugins just do not add items to context menu for inappropriate contexts.

I'll send patch now.

Change History (3)

comment:1 Changed 5 years ago by Jakub Ś

This is sort of duplicate of #12716 where problem for feature request was mentions but please continu this particular part here.

comment:2 Changed 5 years ago by Jakub Ś

Status: newconfirmed
Version: 3.0

comment:3 Changed 5 years ago by Danil

Pull request: https://github.com/ckeditor/ckeditor-dev/pull/147

Context menu now contains permanent cut/copy menu items (disabled when selection is empty). Is it ok?

We could also modify contextmenu plugin, so it would hide disabled items. Not sure.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy