Opened 9 years ago
Closed 8 years ago
#12724 closed New Feature (fixed)
Use notifications in upload widget
Reported by: | Piotr Jasiun | Owned by: | Piotr Jasiun |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
Component: | General | Version: | |
Keywords: | Cc: |
Description (last modified by )
Upload widget should use notifications instead of console to inform user about progress and warning.
The prefect solution would be to show one progress notification for multiple uploads.
TODO: Remove the console.log from the uploadwidget plugin.
Change History (7)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Status: | new → confirmed |
comment:3 Changed 8 years ago by
Owner: | set to Piotr Jasiun |
---|---|
Status: | confirmed → assigned |
comment:4 Changed 8 years ago by
Status: | assigned → review |
---|
Working on this ticket I found 3 related issues:
- #12896, this branch is based on #12896, because otherwise behavior does not make sense,
- #12901, creating tests it was very weird that upload needs to create two notifications,
- git:7155887,
notificationUpdate
cancel behavior had to be changed, as described in docs and comment.
Changes are done and thanks to notification aggregator all uploads are displayed in one notification (excluding warning and success messages). Changes in t/12724.
comment:5 Changed 8 years ago by
Status: | review → review_failed |
---|
I pushed a rebased branch:t/12724 with some small corrections in docs and tests.
However, I spotted a bug. I opened http://tests.ckeditor.dev:1030/tests/plugins/uploadwidget/manual/image and dropped a file there. The progress goes to 13% and then I see a success message. The file I use has 74kb (1000/74 == 13).
comment:6 Changed 8 years ago by
Status: | review_failed → review |
---|
I pushed a changes in XHR mock so it works fine with every file size.
comment:7 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Fixed on major with git:22b9485.
Related: #11461, #11580.