Opened 5 years ago

Last modified 5 years ago

#12721 assigned Task

Adopt the CKEditor Boilerplate project

Reported by: Frederico Caldeira Knabben Owned by: Piotrek Koszuliński
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

The CKEditor 4 repos should adopt the CKEditor Boilerplate project.

Change History (6)

comment:1 Changed 5 years ago by Frederico Caldeira Knabben

The ckeditor-dev master has been merged with the boilerplate in the boilerplate branch.

comment:2 Changed 5 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: newreview

comment:3 Changed 5 years ago by Piotrek Koszuliński

Status: reviewreview_failed

The JSCS and JSHint configs were not merged, so running grunt jshint:all gives 13k errors and running grunt jscs:all gives a JSCS error because JSCS is run against /dev/builder/release (I fixed this recently on master).

I have also other comments about the boilerplate repo. I'll create a ticket with them in the boilerplate repo. Let's have boilerplate polished first.

comment:4 Changed 5 years ago by Piotrek Koszuliński

comment:5 Changed 5 years ago by Piotrek Koszuliński

Owner: changed from Frederico Caldeira Knabben to Piotrek Koszuliński
Status: review_failedreview

I pushed branch:t/12721.

comment:6 Changed 5 years ago by Piotrek Koszuliński

Status: reviewassigned

I merged the branch to master with git:cfae144.

I want to keep this ticket opened to remind me about the tasks documentation in README. I didn't have time to work on it today.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy