Opened 4 years ago

Closed 4 years ago

#12746 closed New Feature (fixed)

Config option to hide image2's resizer

Reported by: Piotrek Koszuliński Owned by: Artur Delura
Priority: Normal Milestone: CKEditor 4.5.0 Beta
Component: General Version: 4.3 Beta
Keywords: Cc:

Description (last modified by Piotrek Koszuliński)

As explained in http://dev.ckeditor.com/ticket/12615#comment:14 and https://github.com/ckeditor/ckeditor-docs/issues/51 we need an option to disable the resizer without removing the width and height attribute (it's now possible to disallow them and resizer automatically disappears).

I'd also love if we could extract the code needed for the resizer to a separate plugin. The setupResizerfunction has 200LOC plus there's 30LOC of CSS, so that could be something. And there's nothing more there, so that would be an entire feature, which after some improvements perhaps could be reused by other plugins (like video embedding). But I'm afraid that we won't have enough time...

Change History (6)

comment:1 Changed 4 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 4 years ago by Piotrek Koszuliński

Type: BugNew Feature

comment:3 Changed 4 years ago by Piotrek Koszuliński

Description: modified (diff)

comment:4 Changed 4 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:5 Changed 4 years ago by Artur Delura

Status: assignedreview

Changes and tests in branch:t/12746.

comment:6 Changed 4 years ago by Piotr Jasiun

Resolution: fixed
Status: reviewclosed

I agree that it would be good to move resizer to the separate plugin, but at this stage we have to focus on closing tickets. Resizer as a separate plugin should work with any widget where dimension attributes make sense. It should not be hard to implement but needs some API and few tests, what is time consuming. Also if resizer become, one day, a separate plugin which can work with multiple widget types it would still make some sense to have an configuration option to disable it only for images. I created a separate ticket: #12963.

Closed with git:30311d4.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy