Opened 10 years ago
Closed 10 years ago
#12747 closed Bug (fixed)
IE: Dropdowns become disabled when in maximize mode.
Reported by: | Jakub Ś | Owned by: | Artur Delura |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.4.7 |
Component: | General | Version: | 4.0 |
Keywords: | IE | Cc: |
Description
- Open replacebycode.html sample
- Click Maximize
- Select header and part of first sentence in first paragraph as shown below:
[Apollo 11 Apollo 11 was the spaceflight that landed ] the first humans,...
- Click and hold mouse button for a few seconds on Styles or Format dropdown.
Result: Dropdown becomes disabled.
Problem can be reproduced in IE8-10 from CKEditor 4.0.
Change History (9)
comment:1 Changed 10 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 10 years ago by
Owner: | set to Artur Delura |
---|---|
Status: | confirmed → assigned |
comment:4 follow-up: 7 Changed 10 years ago by
As we can see above body.$.scrollTop
returns 1633, but actually scroll is 0. This is some ugly browser bug which was removed in IE11. Which is result of mixing various cases like setting some styles to main editable area (maximize plugin) and playing with selection.
What is wrong in CKEditor code is this:
y = box.top + ( !quirks && $docElem.scrollTop || body.$.scrollTop );
When $docElem.scrollTop
is 0 and we are not in quirks mode it pick value which is ment to be used only in quirks. To fix this issue I did this:
y = box.top + ( quirks ? body.$.scrollTop : $docElem.scrollTop );
comment:6 Changed 10 years ago by
Status: | assigned → review |
---|
comment:7 Changed 10 years ago by
Replying to a.delura:
As we can see above
body.$.scrollTop
returns 1633, but actually scroll is 0. This is some ugly browser bug which was removed in IE11. Which is result of mixing various cases like setting some styles to main editable area (maximize plugin) and playing with selection.What is wrong in CKEditor code is this:
y = box.top + ( !quirks && $docElem.scrollTop || body.$.scrollTop );
When
$docElem.scrollTop
is 0 and we are not in quirks mode it pick value which is ment to be used only in quirks. To fix this issue I did this:
y = box.top + ( quirks ? body.$.scrollTop : $docElem.scrollTop );
It reminded me about https://github.com/ckeditor/ckeditor-dev/commit/056c66574aa7d555cf03dc372fb91ae2c48c5458 :D
comment:8 Changed 10 years ago by
Milestone: | → CKEditor 4.4.7 |
---|---|
Status: | review → review_passed |
Great job with the patch. I only needed to improve the test, because many times I couldn't reproduce the issue. It turned out that the selection must be made in a specific way.
comment:9 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed on master with git:69263d0.
Here top style is set with wrong value.
The above happens because this returns a weird big value.
And again the above happens because here
So we end up with 1633 but should be 0.