Opened 9 years ago
Last modified 8 years ago
#12778 confirmed Bug
Cannot delete paragraph before and after a widget
Reported by: | Wiktor Walc | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | General | Version: | 4.3 Beta |
Keywords: | Support | Cc: |
Description (last modified by )
Found in Chrome, confirmed also on Firefox.
- Create a table
- Insert a widget (e.g. Enhanced Image) in a table cell (note: it works only in CKEditor 4.4.1+ #11798)
- See that below widget an empty paragraph is created. If this additional space is disturbing for somebody, one cannot remove it.
This issue can also be reproduced directly in body: http://stackoverflow.com/questions/30262191/ckeditor-how-to-delete-empty-paragraphs-before-and-between-widgets
To reproduce try this code:
<table border="1" cellpadding="1" cellspacing="1" style="width:500px"> <tbody> <tr> <td> </td> <td> <figure class="image"><img alt="dfgdfg" height="480" src="assets/image1.jpg" width="377" /> <figcaption>Caption</figcaption> </figure> <p> </p> </td> </tr> <tr> <td> </td> <td> </td> </tr> </tbody> </table>
There is one interesting method to actually remove the element. But this is so counter-intuitive that it should not be considered as a correct solution.
- Put the cursor in the
<p>
element that you want to removed
- Select
p
in elements path (see that additionalbr
showed up in the elements path automatically)
- Press
Backspace
. Now the paragraph is gone (although slightly different visual result is in Chrome and Firefox).
Attachments (3)
Change History (10)
Changed 9 years ago by
Attachment: | widget_table.png added |
---|
comment:1 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Status: | new → confirmed |
Changed 9 years ago by
Attachment: | cursor_in_p.png added |
---|
Changed 9 years ago by
Attachment: | p_bogus_br.png added |
---|
comment:2 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Keywords: | Support added |
comment:3 Changed 9 years ago by
comment:4 Changed 8 years ago by
Description: | modified (diff) |
---|---|
Summary: | Cannot delete a paragraph inside the table if widget is inside a table cell → Cannot delete paragraph before and after a widget |
Version: | → 4.3 Beta |
comment:5 Changed 8 years ago by
This would require some additional rules for delete and backspace, so if the current paragraph is already empty they should remove it instead of focusing widget. This code could land e.g. here: https://github.com/ckeditor/ckeditor-dev/blob/3a10930/core/selection.js#L339-L365.
comment:6 Changed 8 years ago by
If anyone wants to contribute a patch, then:
- here are tests for the existing behaviour - https://github.com/ckeditor/ckeditor-dev/blob/3a109301b738d9998f132b8030d1b1dbe507c92f/tests/core/selection/fake.js#L874-L906
- here is a brand new contributing code guide - http://docs.ckeditor.com/#!/guide/dev_contributing_code
I cannot delete the first
<p> </p>
if it's followed by<figure>
. I tried this with Chrome.