#12793 closed Bug (fixed)
[IE8] Red tests on major
Reported by: | Piotr Jasiun | Owned by: | Piotrek Koszuliński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
Component: | General | Version: | |
Keywords: | Cc: |
Description
2 red tests on major on IE8:
http://tests.ckeditor.dev:1030/tests/plugins/widget/nestedwidgets
pasted widget is focused
http://tests.ckeditor.dev:1030/tests/plugins/widget/widgetsintegration
data.focusInited was passed
Change History (11)
comment:1 Changed 10 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 10 years ago by
Owner: | set to Artur Delura |
---|---|
Status: | confirmed → assigned |
comment:3 Changed 10 years ago by
comment:4 Changed 10 years ago by
Status: | assigned → review |
---|
Changes in branch:t/12793. Problem was caused by wrongly set property processedWidgetOnly
in IE8.
comment:5 Changed 10 years ago by
Could you elaborate more about the second problem on IE8? Mainly - what's inside evt.data.dataValue
on IE8 and what's on other browsers.
comment:6 Changed 10 years ago by
Thats a good question. this function call return HTML with new line character at the very beginning. And this value becomes later evt.data.dataValue
.
comment:8 Changed 10 years ago by
This value might be not okay as an output from getOuterHtml
. Nevethless this value is valid as an input in processDataForInsertion
function so should be handled properly.
comment:9 Changed 10 years ago by
Status: | review → review_failed |
---|
OK, the solution makes sense. We need to improve naming and tests though.
- Write a test in editable/insertion.js that when insertHtml wrapped content. Check that in #toHtml listener the evt.data.wrappedForWhitespaces is set.
- Rename options.wrappedForWhitespaces to options.wrappedData. The documentation should say that the insertHtml() function sets this option to true when it wraps content with spans to preserve spaces. Also, you need to document evt.data.wrappedData in the #toHtml event.
- In editable.js reuse the
protect
variable instead of creating new.
comment:10 Changed 9 years ago by
Owner: | changed from Artur Delura to Piotrek Koszuliński |
---|---|
Status: | review_failed → assigned |
comment:11 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
With reference to ticket:12008:
I'm gonna ignore first test on IE8 ]:->