Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12793 closed Bug (fixed)

[IE8] Red tests on major

Reported by: Piotr Jasiun Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.5.0 Beta
Component: General Version:
Keywords: Cc:

Description

Change History (11)

comment:1 Changed 4 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 4 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:3 Changed 4 years ago by Artur Delura

With reference to ticket:12008:

Very likely we'll not support nested widgets in IE8 for some time.

I'm gonna ignore first test on IE8 ]:->

comment:4 Changed 4 years ago by Artur Delura

Status: assignedreview

Changes in branch:t/12793. Problem was caused by wrongly set property processedWidgetOnly in IE8.

comment:5 Changed 4 years ago by Piotrek Koszuliński

Could you elaborate more about the second problem on IE8? Mainly - what's inside evt.data.dataValue on IE8 and what's on other browsers.

comment:6 Changed 4 years ago by Artur Delura

Thats a good question. this function call return HTML with new line character at the very beginning. And this value becomes later evt.data.dataValue.

Last edited 4 years ago by Artur Delura (previous) (diff)

comment:7 Changed 4 years ago by Piotrek Koszuliński

So isn't a simple trim() an easier solution?

comment:8 Changed 4 years ago by Artur Delura

This value might be not okay as an output from getOuterHtml. Nevethless this value is valid as an input in processDataForInsertion function so should be handled properly.

comment:9 Changed 4 years ago by Piotrek Koszuliński

Status: reviewreview_failed

OK, the solution makes sense. We need to improve naming and tests though.

  1. Write a test in editable/insertion.js that when insertHtml wrapped content. Check that in #toHtml listener the evt.data.wrappedForWhitespaces is set.
  2. Rename options.wrappedForWhitespaces to options.wrappedData. The documentation should say that the insertHtml() function sets this option to true when it wraps content with spans to preserve spaces. Also, you need to document evt.data.wrappedData in the #toHtml event.
  3. In editable.js reuse the protect variable instead of creating new.

comment:10 Changed 4 years ago by Piotrek Koszuliński

Owner: changed from Artur Delura to Piotrek Koszuliński
Status: review_failedassigned

comment:11 Changed 4 years ago by Piotrek Koszuliński

Resolution: fixed
Status: assignedclosed

Fixed on major with git:9980296.

Perfect tests run:

3928 passed / 0 failed in 10m 50s 695ms - 100%

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy