Opened 11 years ago
Closed 11 years ago
#12877 closed Bug (fixed)
Notifications has wrong possition in replaceByCode sample
| Reported by: | Piotr Jasiun | Owned by: | Piotr Jasiun |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
After the fix for manual test left margin become wrong in samples.
Attachments (1)
Change History (8)
comment:1 Changed 11 years ago by
| Owner: | set to Piotr Jasiun |
|---|---|
| Status: | new → assigned |
comment:2 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 11 years ago by
| Status: | review_failed → review |
|---|
Manual test pushed to the same branch. Branch rebased on the newest major.
comment:5 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Notification is still not centered correctly. It is visible on http://tests.ckeditor.dev:1030/tests/plugins/notification/manual/bodypossition On major it happens naturally only in the second editor. On t/12877 it's visible on both.
(There's 20px more on its left than on its right side.)
I guess this is a separate bug, though. If you agree, you can close this ticket.
Changed 11 years ago by
| Attachment: | notif-centering.png added |
|---|
comment:6 Changed 11 years ago by
I forgot to mention that I pushed branch:t/12877 with one additional commit.
comment:7 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
I created separated ticket for the alignment #13036. It is separate bug. Closed with git:c415544.
Note: See
TracTickets for help on using
tickets.
This is because if "body" has margin and position != static then notification area position rely on body position, otherwise is related to (0,0).
I have pushed fix and I am not proved of it. I think that notification area should have always fixed position, but this is a bigger change.
Changes in t/12877.