Opened 4 years ago

Closed 4 years ago

#12877 closed Bug (fixed)

Notifications has wrong possition in replaceByCode sample

Reported by: Piotr Jasiun Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.5.0 Beta
Component: General Version:
Keywords: Cc:

Description

After the fix for manual test left margin become wrong in samples.

Attachments (1)

notif-centering.png (62.7 KB) - added by Piotrek Koszuliński 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: newassigned

comment:2 Changed 4 years ago by Piotr Jasiun

Status: assignedreview

This is because if "body" has margin and position != static then notification area position rely on body position, otherwise is related to (0,0).

I have pushed fix and I am not proved of it. I think that notification area should have always fixed position, but this is a bigger change.

Changes in t/12877.

comment:3 Changed 4 years ago by Piotrek Koszuliński

Status: reviewreview_failed

Missing manual test.

comment:4 Changed 4 years ago by Piotr Jasiun

Status: review_failedreview

Manual test pushed to the same branch. Branch rebased on the newest major.

comment:5 Changed 4 years ago by Piotrek Koszuliński

Status: reviewreview_passed

Notification is still not centered correctly. It is visible on http://tests.ckeditor.dev:1030/tests/plugins/notification/manual/bodypossition On major it happens naturally only in the second editor. On t/12877 it's visible on both.

(There's 20px more on its left than on its right side.)

I guess this is a separate bug, though. If you agree, you can close this ticket.

Last edited 4 years ago by Piotrek Koszuliński (previous) (diff)

Changed 4 years ago by Piotrek Koszuliński

Attachment: notif-centering.png added

comment:6 Changed 4 years ago by Piotrek Koszuliński

I forgot to mention that I pushed branch:t/12877 with one additional commit.

comment:7 Changed 4 years ago by Piotr Jasiun

Resolution: fixed
Status: review_passedclosed

I created separated ticket for the alignment #13036. It is separate bug. Closed with git:c415544.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy