#13036 closed Bug (fixed)
Notifications are 10px more to the right
| Reported by: | Piotr Jasiun | Owned by: | Artur Delura |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 |
| Component: | General | Version: | 4.5.0 Beta |
| Keywords: | Cc: |
Description (last modified by )
Working on #12877 shows that notifications are not exactly in the middle of the editor. The are moved to the right.
Attachments (1)
Change History (10)
Changed 10 years ago by
| Attachment: | notif-centering.png added |
|---|
comment:1 Changed 10 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 10 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 10 years ago by
| Owner: | set to Artur Delura |
|---|---|
| Status: | confirmed → assigned |
comment:4 Changed 10 years ago by
comment:5 Changed 10 years ago by
| Status: | assigned → review |
|---|
comment:6 Changed 10 years ago by
| Status: | review → review_failed |
|---|
http://tests.ckeditor.dev:1030/tests/plugins/notification/manual/classic
Notifications are not visible if the editor is in the center.
comment:7 Changed 10 years ago by
| Status: | review_failed → review |
|---|
Good catch. Changes in branch:t/13036b.
comment:8 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Fixed on major with git:decf792.
Note: See
TracTickets for help on using
tickets.
Changes and tests in branch:t/13036. BTW. I don't like the idea that notifications are positioned via JavaScript. I think it's a job for rendering engines, and we should only manipulate classes for positioning. There is a lot custom position logic behind which is hard to maintain. For example border haven't been taken into consideration.