Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13036 closed Bug (fixed)

Notifications are 10px more to the right

Reported by: Piotr Jasiun Owned by: Artur Delura
Priority: Normal Milestone: CKEditor 4.5.0
Component: General Version: 4.5.0 Beta
Keywords: Cc:

Description (last modified by Piotr Jasiun)

Working on #12877 shows that notifications are not exactly in the middle of the editor. The are moved to the right.

Attachments (1)

notif-centering.png (62.7 KB) - added by Piotr Jasiun 3 years ago.

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by Piotr Jasiun

Attachment: notif-centering.png added

comment:1 Changed 3 years ago by Piotr Jasiun

Description: modified (diff)

comment:2 Changed 3 years ago by Jakub Ś

Status: newconfirmed

comment:3 Changed 3 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:4 Changed 3 years ago by Artur Delura

Changes and tests in branch:t/13036. BTW. I don't like the idea that notifications are positioned via JavaScript. I think it's a job for rendering engines, and we should only manipulate classes for positioning. There is a lot custom position logic behind which is hard to maintain. For example border haven't been taken into consideration.

comment:5 Changed 3 years ago by Artur Delura

Status: assignedreview

comment:6 Changed 3 years ago by Piotrek Koszuliński

Status: reviewreview_failed

http://tests.ckeditor.dev:1030/tests/plugins/notification/manual/classic

Notifications are not visible if the editor is in the center.

comment:7 Changed 3 years ago by Artur Delura

Status: review_failedreview

Good catch. Changes in branch:t/13036b.

comment:8 Changed 3 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Fixed on major with git:decf792.

comment:9 Changed 3 years ago by Piotrek Koszuliński

We forgot to update tests - fixed with git:f946948.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy