Opened 5 years ago

Last modified 5 years ago

#12880 confirmed New Feature

Disabled dialog buttons appear the same as enabled dialog buttons

Reported by: Tyler Owned by:
Priority: Normal Milestone:
Component: UI : Skins Version: 4.0
Keywords: Cc:

Description

Usking kama skin, if a button is disabled in a dialog via the following:

CKEDITOR.dialog.add('dialog', function () {

return {

... onShow: function () {

this.disableButton('ok');

} ...

}

});

The button disables properly but no related styling for being disabled are applied and it appears identical to an enabled button.

I was able to fix this with a few CSS overrides:

a.cke_dialog_ui_button_ok.cke_disabled:hover, a.cke_dialog_ui_button_ok.cke_disabled:focus, a.cke_dialog_ui_button_ok.cke_disabled:active {

background-position: 0px -1144px;

}

a.cke_dialog_ui_button_cancel.cke_disabled:hover, a.cke_dialog_ui_button_cancel.cke_disabled:focus a.cke_dialog_ui_button_cancel.cke_disabled:active {

background-position: 0px -1105px;

} a.cke_dialog_ui_button.cke_disabled:hover, a.cke_dialog_ui_button.cke_disabled:focus, a.cke_dialog_ui_button.cke_disabled:active {

background-position: 0px -1069px;

}

a.cke_disabled {

opacity: 0.3;

}

Change History (3)

comment:1 Changed 5 years ago by Tyler

Can't see a way to edit ticket, the first two rules should read :

a.cke_dialog_ui_button_ok.cke_dialog_ui_button.cke_disabled:hover,
a.cke_dialog_ui_button_ok.cke_dialog_ui_button.cke_disabled:focus,
a.cke_dialog_ui_button_ok.cke_dialog_ui_button.cke_disabled:active {
  background-position: 0px -1144px;
}

a.cke_dialog_ui_button_cancel.cke_dialog_ui_button.cke_disabled:hover,
a.cke_dialog_ui_button_cancel.cke_dialog_ui_button.cke_disabled:focus
a.cke_dialog_ui_button_cancel.cke_dialog_ui_button.cke_disabled:active {
  background-position: 0px -1105px;
}

comment:2 Changed 5 years ago by Jakub Ś

The same goes for Moono. I see that both skins have no styles for "disabled buttons" defined.

I see it however more as a feature and not a bug.

comment:3 Changed 5 years ago by Jakub Ś

Status: newconfirmed
Type: BugNew Feature
Version: 4.4.64.0
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy