Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12930 closed Bug (fixed)

Remove truncated-mathjax from the test directory

Reported by: Piotr Jasiun Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.4.8
Component: General Version:
Keywords: Cc: wim.leers@…

Description

MathJax is under Apache licence which we can not use in our project so this code should be removed.

Change History (9)

comment:1 Changed 4 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: newassigned

comment:2 Changed 4 years ago by Piotr Jasiun

I pushed changes into master which remove MathJax and use CDN instead and merged master into major, so there is no MathJax code in the CKEditor main branches anymore.

comment:3 Changed 4 years ago by Piotr Jasiun

Status: assignedreview

I have also introduced bender.config.mathJaxLibPath to tests so it is possible to use local mathJax. Changes in t/12930.

comment:4 Changed 4 years ago by Wim Leers

Cc: wim.leers@… added

comment:5 Changed 4 years ago by Frederico Caldeira Knabben

There should be no default configuration. Just like the CDN problem we have in the plugin code, it's not just a matter of having it configurable but to not have it hardcoded.

We must make it optional... if bender is not configured with the MathJax path the tests are ignored.

comment:6 Changed 4 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

comment:7 Changed 4 years ago by Piotr Jasiun

Status: review_failedreview

I removed links to the CDN from tests and added assertion with message. CDN needs to be removed also from plugin, but because it may break backward compatibility it is handled by another ticket assigned to the major release (4.5). Changes in t/12930.

comment:8 Changed 4 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:9 Changed 4 years ago by Piotr Jasiun

Resolution: fixed
Status: review_passedclosed

Closed with git:d3b2b45.

Last edited 4 years ago by Piotr Jasiun (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy