Opened 10 years ago
Closed 10 years ago
#12965 closed New Feature (fixed)
Enhancements for Uploads Repository API
Reported by: | Piotr Jasiun | Owned by: | Piotr Jasiun |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.5.0 Beta |
Component: | General | Version: | |
Keywords: | Cc: |
Description (last modified by )
Uploads Repository is missing some important methods:
repository.isFinished
- returns true if all uploads are done,repository.loaders
- returns all loaders in upload repository.
It would be useful if one wants to block save button until all uploads are done.
Change History (7)
comment:1 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 10 years ago by
Status: | new → confirmed |
---|
comment:3 Changed 10 years ago by
comment:4 Changed 10 years ago by
Summary: | Uploads Repository API → Enhancements for Uploads Repository API |
---|
comment:5 Changed 10 years ago by
Owner: | set to Piotr Jasiun |
---|---|
Status: | confirmed → assigned |
comment:6 Changed 10 years ago by
Status: | assigned → review |
---|
Done. Changes in t/12965.
Changes:
uploadRepository.loaders
is now global; I can imagine some scenarios when user want to get all activeuploads
or all statuses; there is no reasone to keep it private;- introduced
uploadRepository.isFinished
andloader.isFinished
; these methods could be very useful if user want to prevent some actions until all uploads are done; - removed
uploadRepository.get
; sinceloaders
is global this method do nothing.
comment:7 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Merge to major with git:6fce1f8.
This is a pretty important feature since large uploads may take a while.