[Firefox] Red tests after #11586

[Piotr Jasiun]

On Firefox:

• 1 failed: ​http://tests.ckeditor.dev:1030/tests/plugins/table/table
• 3 failed: ​http://tests.ckeditor.dev:1030/tests/plugins/clipboard/paste
• 1 failed: ​http://tests.ckeditor.dev:1030/tests/core/selection/fake

First bad commit for all of them: ​git:7580ae7 which is part of #11586.

[Piotrek Koszuliński]

Pushed ​branch:t/13001 with a patch.

It turned out to be a constellation of 3 bugs that all this worked before #11586. First - range.extractContents was broken and didn't extract selected bogus <br> (this bug was fixed by #11586 which touched all 3 contents methods, hence the red tests). Second, fixBlock, based on that incorrect behaviour, didn't worry about duplicating bogus <br> that could already exist in the range container. And finally, Firefox's absolutely creative bug which I fortunately already knew from other tickets. Namely, Firefox appends its own bogus <br> when the editable becomes empty, and that would be ok, but it also moves it around when doing operations on that DOM. The bug I reported previously - ​https://bugzilla.mozilla.org/show_bug.cgi?id=911201. The bug that, when fixed, will solve that <br> problems at all - ​https://bugzilla.mozilla.org/show_bug.cgi?id=1098151

PS. I wrote tests for createBookmark, because before I understood that it's FF I was blaming it for placing the spans incorrectly. PPS. I left that patch for all browsers, because it also resolves the situation when for some reason range was placed after the bogus <br>. Thanks to the patch the range will be moved before the bogus <br> which is a more correct place from selection perspective.

[Piotr Jasiun]

Sounds like a lot of fun :) Everything works now fine. Closed ​git:975b7ad.