Opened 3 years ago

Closed 3 years ago

#13001 closed Bug (fixed)

[Firefox] Red tests after #11586

Reported by: Piotr Jasiun Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.5.0 Beta
Component: General Version:
Keywords: Cc:

Change History (3)

comment:1 Changed 3 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 3 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed branch:t/13001 with a patch.

It turned out to be a constellation of 3 bugs that all this worked before #11586. First - range.extractContents was broken and didn't extract selected bogus <br> (this bug was fixed by #11586 which touched all 3 contents methods, hence the red tests). Second, fixBlock, based on that incorrect behaviour, didn't worry about duplicating bogus <br> that could already exist in the range container. And finally, Firefox's absolutely creative bug which I fortunately already knew from other tickets. Namely, Firefox appends its own bogus <br> when the editable becomes empty, and that would be ok, but it also moves it around when doing operations on that DOM. The bug I reported previously - https://bugzilla.mozilla.org/show_bug.cgi?id=911201. The bug that, when fixed, will solve that <br> problems at all - https://bugzilla.mozilla.org/show_bug.cgi?id=1098151

PS. I wrote tests for createBookmark, because before I understood that it's FF I was blaming it for placing the spans incorrectly. PPS. I left that patch for all browsers, because it also resolves the situation when for some reason range was placed after the bogus <br>. Thanks to the patch the range will be moved before the bogus <br> which is a more correct place from selection perspective.

Last edited 3 years ago by Piotrek Koszuliński (previous) (diff)

comment:3 Changed 3 years ago by Piotr Jasiun

Resolution: fixed
Status: reviewclosed

Sounds like a lot of fun :) Everything works now fine. Closed git:975b7ad.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy