Opened 3 years ago

Closed 3 years ago

#13003 closed Bug (fixed)

Anchors are uploaded

Reported by: Piotr Jasiun Owned by: Artur Delura
Priority: Must have (possibly next milestone) Milestone: CKEditor 4.5.0
Component: General Version: 4.5.0 Beta
Keywords: Cc:

Description

  1. Open http://ckeditor.dev/plugins/uploadwidget/dev/upload.html
  2. Drag anchor and drop it somewhere else in the editor.

Result: Anchor is uploaded.

Change History (9)

comment:1 Changed 3 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.5.0 BetaCKEditor 4.5.0

comment:2 Changed 3 years ago by Jakub Ś

Status: newconfirmed

comment:3 Changed 3 years ago by Piotrek Koszuliński

Priority: NormalHigh

comment:4 Changed 3 years ago by Piotrek Koszuliński

Version: 4.5.0 Beta

comment:5 Changed 3 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:6 Changed 3 years ago by Artur Delura

We can prevent this by not calling paste event callback here by adding such check:

if ( imgs.getItem( 0 ) && imgs.getItem( 0 ).hasClass( 'cke_anchor' ) ) {
	return;
}

or at the very beginning by using some simple regular expression.

The question is whether we have more cases like this one. And whether we should handle it using some more general approach.

comment:7 Changed 3 years ago by Artur Delura

Done by checking whether element if a fake object. Changes and tests in branch:t/13003.

Last edited 3 years ago by Artur Delura (previous) (diff)

comment:8 Changed 3 years ago by Artur Delura

Status: assignedreview

comment:9 Changed 3 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Fixed on major with git:26b9d35.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy