Opened 10 years ago
Last modified 10 years ago
#13009 confirmed Bug
[Notification Aggregator] Counting _doneWeights is over-complicated
Reported by: | Piotr Jasiun | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | General | Version: | 4.5.0 Beta |
Keywords: | Cc: |
Description (last modified by )
Working on #12955 we agreed that, since counting _doneWeights
and _totalWeights
is pretty simple and can be stored in redundant variables, counting _doneWeights
is over-complicated and can be a reason of the future bugs. Tasks should give its done wights to aggregator and it should could sum of them, when it is needed.
Also with the current implementation it is not possible to update with negative weight, for no apparent reason.
Since this changes may causes some changes in API this ticket should be done before releasing 4.5.0.
Change History (4)
comment:1 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 10 years ago by
comment:3 Changed 10 years ago by
Milestone: | CKEditor 4.5.0 |
---|
Quoting myself:
Anyway, one broken case doesn't mean that the whole approach is bad, so please just fix it ;).
I don't see a reason to work on this. There's one bug reported right now. Let's see if we really see some problems when resolving it and then we can make a decision.
comment:4 Changed 10 years ago by
Status: | new → confirmed |
---|---|
Version: | → 4.5.0 Beta |
I confirming this issue as @pjasiun comment sounds more reasonable to me.
@Reinmar, feel free to comment or even close this ticket if you don't agree.
This ticket should be done after #12901 is closed.