Opened 8 years ago
Closed 8 years ago
#13138 closed Bug (fixed)
[Basic toolbar conf.] Toggle empty elements button label is unclear
| Reported by: | Piotrek Koszuliński | Owned by: | Artur Delura |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 |
| Component: | Toolbar Configurator | Version: | 4.5.0 Beta |
| Keywords: | Cc: |
Description
First of all it should be "groups", not "elements".
Second, it should be:
- "Show empty toolbar groups" when they are hidden.
- "Hide empty toolbar groups" when they are visible.
Change History (10)
comment:1 Changed 8 years ago by
| Status: | new → confirmed |
|---|---|
| Version: | → 4.5.0 (GitHub - major) |
comment:2 Changed 8 years ago by
| Owner: | set to Artur Delura |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 8 years ago by
comment:4 Changed 8 years ago by
The ticket does not say anything about the background. It's only about changing the text according to the button state.
comment:5 Changed 8 years ago by
Although, please ask also @anowodzinski. We may indeed not need the additional color change when the text changes.
comment:6 Changed 8 years ago by
Please focus on the text only in this ticket. I handle all visual aspects in #13192.
comment:8 Changed 8 years ago by
| Status: | assigned → review |
|---|
comment:9 Changed 8 years ago by
| Component: | General → Toolbar Configurator |
|---|
comment:10 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Fixed with git:813cec6 on major.
Note: See
TracTickets for help on using
tickets.
So whe sould get rid of button blue background when empty groups are visible?