Opened 10 years ago

Closed 10 years ago

#13138 closed Bug (fixed)

[Basic toolbar conf.] Toggle empty elements button label is unclear

Reported by: Piotrek Koszuliński Owned by: Artur Delura
Priority: Normal Milestone: CKEditor 4.5.0
Component: Toolbar Configurator Version: 4.5.0 Beta
Keywords: Cc:

Description

First of all it should be "groups", not "elements".

Second, it should be:

  • "Show empty toolbar groups" when they are hidden.
  • "Hide empty toolbar groups" when they are visible.

Change History (10)

comment:1 Changed 10 years ago by Piotrek Koszuliński

Status: newconfirmed
Version: 4.5.0 (GitHub - major)

comment:2 Changed 10 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:3 Changed 10 years ago by Artur Delura

So whe sould get rid of button blue background when empty groups are visible?

comment:4 Changed 10 years ago by Piotrek Koszuliński

The ticket does not say anything about the background. It's only about changing the text accordingly to the button state.

Version 0, edited 10 years ago by Piotrek Koszuliński (next)

comment:5 Changed 10 years ago by Piotrek Koszuliński

Although, please ask also @anowodzinski. We may indeed not need the additional color change when the text changes.

comment:6 Changed 10 years ago by Olek Nowodziński

Please focus on the text only in this ticket. I handle all visual aspects in #13192.

comment:7 Changed 10 years ago by Artur Delura

Changes in branch:t/13138.

comment:8 Changed 10 years ago by Artur Delura

Status: assignedreview

comment:9 Changed 10 years ago by Wiktor Walc

Component: GeneralToolbar Configurator

comment:10 Changed 10 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Fixed with git:813cec6 on major.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy