Opened 8 years ago
Closed 8 years ago
#13185 closed Bug (fixed)
[Toolbar configurator] Wrong position of the suggestion box if there is not enough space below caret.
| Reported by: | Piotr Jasiun | Owned by: | Artur Delura |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 |
| Component: | Toolbar Configurator | Version: | 4.5.0 Beta |
| Keywords: | Cc: |
Description (last modified by )
On all browsers.
If there is not enough space in the viewport bellow the caret, the suggestion box is shown in the wrong position (should be directly above the caret).
Attachments (1)
Change History (12)
Changed 8 years ago by
| Attachment: | Screenshot from 2015-04-14 11:52:59.png added |
|---|
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 8 years ago by
| Status: | new → confirmed |
|---|
comment:4 Changed 8 years ago by
| Milestone: | → CKEditor 4.5.0 |
|---|
comment:5 Changed 8 years ago by
| Owner: | set to Artur Delura |
|---|---|
| Status: | confirmed → assigned |
comment:6 Changed 8 years ago by
| Status: | assigned → review |
|---|
Changes in branch:t/13185. Please check, merge this issue before related ones and let me know, because it highly influence advanced toolbar behaviour. So I could check whether other issues won't break.
comment:7 Changed 8 years ago by
| Component: | General → Toolbar Configurator |
|---|
comment:8 Changed 8 years ago by
| Status: | review → review_failed |
|---|
After switching to the branch:
index.html:139 GET http://localhost/ckeditor-dev/samples/toolbarconfigurator/lib/codemirror/javascript.js
comment:10 Changed 8 years ago by
| Status: | review_failed → review |
|---|
Fixed this one and add yet recet version which is 5.2.
comment:11 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
It's still not perfect on some browsers (FF, IE8), but it's definitely better now. On FF and IE8 the panel is displayed below the caret even though there's not enough space, but we can live with this issue, because it's not actually that common. Most importantly - the panel is visible.
Fixed on major with git:27736b3.
See attachment.