Opened 10 years ago
Closed 10 years ago
#13344 closed Bug (fixed)
It is possible to remove/change editor contents in readonly mode
Reported by: | Jakub Ś | Owned by: | Tade0 |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.4.8 |
Component: | General | Version: | 4.4.2 |
Keywords: | Blink Webkit Support | Cc: |
Description
Issue reported on our support channel.
I have a use case where CKEditor is opened in readonly based on user’s privilege however I am able to merge paragraphs or delete content even when readonly is set to true.
- In first case I select two paragraphs and press delete key. The selected content gets deleted.
- In second case I try to place cursor at start of second paragraph and press backspace. The paragraphs get merged.
Let me know if there is any workaround to fix it.
Attachments (1)
Change History (8)
Changed 10 years ago by
Attachment: | 2015-06-01_1147.swf added |
---|
comment:1 Changed 10 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 10 years ago by
comment:3 Changed 10 years ago by
Milestone: | → CKEditor 4.4.8 |
---|
comment:4 Changed 10 years ago by
Owner: | set to Tade0 |
---|---|
Status: | confirmed → review |
Changes in branch:t/13344.
comment:5 Changed 10 years ago by
Status: | review → review_failed |
---|
- Tests are missing (only automated ones in this case -
tests/editable/keystrokes/delbackspacequirks/*
. - Your branch is anchored to some old commit. It should diverge from master.
comment:7 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Fixed on master with git:e857553.
I made two changes:
- Made sure that read-only mode is disabled when a test fail.
- Added a manual test, because I realised that I'm not 100% sure that we fixed the reported TC :D. There could be some other listener somewhere which might be changing the content.
I guess it's one of the fixes for #9998. It should check if the editor is in readonly mode and I guess it doesn't.