Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13447 closed Bug (fixed)

Error while D&D widget by drag handler.

Reported by: Artur Delura Owned by: Artur Delura
Priority: Normal Milestone: CKEditor 4.5.0
Component: UI : Widgets Version: 4.5.0 Beta
Keywords: Cc:

Description

Change History (11)

comment:1 Changed 4 years ago by Artur Delura

Status: newconfirmed

comment:2 Changed 4 years ago by Artur Delura

Owner: set to Artur Delura
Status: confirmedassigned

comment:3 Changed 4 years ago by Artur Delura

Status: assignedreview

Fix related to #13011. Changes in branch:t/13447.

comment:4 Changed 4 years ago by Artur Delura

I think it might be a good idea to add also checking whether dragRange is defined as well.

comment:5 Changed 4 years ago by Artur Delura

Okay I amend last commit in the branch and pushed it.

comment:6 Changed 4 years ago by Olek Nowodziński

Status: reviewreview_passed

comment:7 Changed 4 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

comment:8 Changed 4 years ago by Olek Nowodziński

Component: GeneralUI : Widgets
Version: 4.5.0 Beta

comment:9 Changed 4 years ago by Olek Nowodziński

Merged into major in git:5d3e96a. Hi Anna!

comment:10 Changed 4 years ago by Anna Tomanek

Great job! ;) Thanks Olek, love you too!

comment:11 Changed 4 years ago by Piotrek Koszuliński

This patch introduces a bug. If dragRange is null then those two properties should be reset. Otherwise old values will be used upon drop what is clearly incorrect. Reported in #13451.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy