[Chrome] It is possible to type in unfocused inline editor

[Jakub Ś]

I have managed to reproduce it only in Chrome from CKEditor 4.0 beta.

1. Go to massive inline creation sample
2. Click into last inline editor (that small one at the very bottom)
3. Press tab - Focus goes to link
4. Star typing

Result - text is being typed into editor.

[Jonathan]

I have also verified the issue exists in version 4.4.7 with the div editing area plugin.

[Tomasz Jakut]

The only working fix is removing the entire selection after focusing element outside the editor. Pushed ​branch:t/13446.

[Olek Nowodziński]

1. I ran tests in Chrome and got over a hundred of Uncaught TypeError: Cannot read property 'getNative' of null errors coming from ​https://github.com/cksource/ckeditor-dev/blob/t/13446/core/focusmanager.js#L161 in many different tests.

2. A selection cached in ​https://github.com/cksource/ckeditor-dev/blob/t/13446/core/focusmanager.js#L153 may be outdated when doBlur() is called in the timout ​https://github.com/cksource/ckeditor-dev/blob/t/13446/core/focusmanager.js#L178-L181. It's unsafe and may be a source of problems in the future.

3. ​https://github.com/cksource/ckeditor-dev/blob/t/13446/core/focusmanager.js#L162 – shouldn't it be editor.window? What would happen to a classic editor in such case?

4. I see no tests for classic editor (wysiwygarea–based).

[Tomasz Jakut]

1, 2. I changed fix to detect inline mode in Chrome, not the existing selection. It seems to fix errors and removes the need of caching selection.

3. Yes, it should be. I've changed that. Classic editor should be not touched (changes for 1. ensures that).
4. I added test for classic editor to check if fix is not touching it (Chrome doesn't clean up selection in classic editor too, but it doesn't cause any errors, because the focus is moved entirely outside editor's window on blur - therefore fix leaves it as it is).

Pushed ​branch:t/13446.

[Marek Lewandowski]

Moving tickets to the next milestone.

[Marek Lewandowski]

Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.

[kkrzton]

Rebased it on current master and updated manual test version tag.

This solution looks like a good approach to solve this issue. However, one unit test is failing http://tests.ckeditor.dev:1030/tests/core/editor/title with Uncaught TypeError: Cannot read property 'hasAscendant' of null .

[Tomasz Jakut]

I've updated code on ​branch:t/13446.

The issue with the test is caused by the fact that handling for editor's blur is fired asynchronously. The invocation of insertText in loop, for all editors cause the blur handler to be fired after focusing the next editor, eventually clearing the selection in this editor's instance – if user is using Chrome and that editors are inline ones. IMO it's a situation very unlike to happen in the real world so fixing just the test should suffice.

I've also simplified checking for the inline editor in focusmanager.js.

[kkrzton]

Fixing tests is fair enough IMO. LGTM!

[kkrzton]

Merged to master with ​8437204.