Toolbar Configurator Error if some plugin requires one of the plugins which TConf tries to remove

[Steve James]

IE11 Full Build with extra plug-ins

Loaded toolbar configurator got browser exception when switching to toolbar advanced mode. (I had the IE debugger loaded.)

I have attached a screen shot and my build-config.js file for reference.

[Steve James]

Screen Capture of error state in IE11 debugger

[Steve James]

My build-config.js file

[Piotrek Koszuliński]

Some 3rd party plugins may not work out of the box. If it requires some configuration options or works under certain conditions, then these conditions may not be met in the toolbar configurator. Then, problems may occur and there's no solution for that as we don't control those plugins.

Question is - how to notify the user about such problems.

Second thing - if the Start sample works, then toolbar configurator should too unless I miss something.

[Piotrek Koszuliński]

I've just realised that tconf tries to remove some plugins to speed it up. This breaks wordcount. So this is a valid issue.

[Jakub Ś]

@SteveTheTechie the problem is WourCount plugin.

First problem is that it requires htmlwriter plugin which configurator tries to remove. This is confirmed bug.

The problem is that this plugin, even after fixing above problem (or simply removing requirement from plugin's code), will not work anyway and break configurator.
This should be reported to plugin author.
There is a method inside plugin counterElement(editorInstance) which evaluets to null and causes exception in code counterElement(editorInstance).innerHTML. Generally plugin is missing some checks whether footer is even available and fail gently (with some console log) if it is not.

[Steve James]

Good work on the troubleshooting!

I do think this does sort of point to the challenges of trying to make the configurator code reliably decipher all of the installed plug-ins and make the Toolbar Configurator work accordingly.

[Szymon Kupś]

It looks like required plugins are loaded properly and error is intentionally placed in timeout to prevent any blocking. It informs that there was a plugin on config.removePlugins list but it was loaded anyway because it is required by some other plugin (in this case htmlwriter plugin is required by wordcount plugin).

Possible solutions:

• Keep whole plugins list without removing anything by toolbar configurator.
• Check if plugins are required by other plugins before removing them by toolbar configurator. Plugin removal is happening on configLoaded event, before loading actual plugins. Checking dependencies in not yet loaded plugins might be tricky.
• Change the way user is informed about plugins that cannot be removed. Now error is thrown and may suggest that something went wrong.

[Piotrek Koszuliński]

Keep whole plugins list without removing anything by toolbar configurator.

Yep. This will be the simplest solution. The list of plugins was trimmed to try to speed up editor initialisation, but we haven't thought about requirements. Let's just deoptimise this. Not a big deal.

[Szymon Kupś]

Deleted code that was responsible for plugin removal by toolbar configurator.
Pushed ​branch:t/13494.

Note: there are still errors caused by wordcount plugin (comment:3) that should be reported to the plugin author.

[Olek Nowodziński]

Merged ​git:894c103 into master.