Opened 3 years ago

Closed 3 years ago

#13603 closed Bug (fixed)

Can't embed BMP images

Reported by: Jonathan Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.5.3
Component: General Version: 4.5.0
Keywords: Cc:

Description

Can drag and drop jpg/gif/png images into the editor, but not bmp files with imageupload plugin.

Change History (8)

comment:1 Changed 3 years ago by Piotr Jasiun

Status: newconfirmed

We will check if it possible to handle BMP files.

comment:2 Changed 3 years ago by Piotr Jasiun

I tested it on Chrome, Firefox, Safari, IE11 and IE10. The key phase is the upload preview when we show image as an element with data in the src attribute (in this case data/bmp). It works very well on all browsers expect IE10 where the preview image is small, it get the size of the text. But I believe it is not a big issue anyway so we can add BMP support.

comment:3 Changed 3 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: confirmedreview

Changes in t/13603.

comment:4 Changed 3 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.5.3
Version: 4.5.14.5.0

comment:5 Changed 3 years ago by Piotr Jasiun

On the other hand we could leave it to users and let them decide what extensions they want this plugin support by:

editor.widgets.registered.uploadimage.supportedTypes = /image\/(jpeg|png|gif|bmp)/

But to make it works supportedTypes should be read from the registered widget definition, not directly from the method parameter.

comment:6 Changed 3 years ago by Piotrek Koszuliński

Status: reviewreview_failed

The test passes even on master. The gif type test also checks nothing. The png type test works.

comment:7 Changed 3 years ago by Piotr Jasiun

Status: review_failedreview

Fixed. Changes in the same branch.

comment:8 Changed 3 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

Merged to master with git:e52e3b8.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy