Opened 10 years ago
Closed 10 years ago
#13655 closed Task (fixed)
Tests: Adding colorbutton plugin to 13590/1 tests breaks them
| Reported by: | Piotrek Koszuliński | Owned by: | Szymon Cofalik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.4 |
| Component: | General | Version: | 4.5.3 |
| Keywords: | Cc: |
Description
- http://tests.ckeditor.dev:1030/tests/tickets/13590/1
- Add colorbutton plugin (it's available in the build test)
- See that on Chrome, FF and IE last two test cases fails.
Since the plugin cannot be removed from the build test (config.removePlugins option does not work as the presence of this plugin is enough to change PFW's behaviour) test results need to be updated.
Change History (6)
comment:1 Changed 10 years ago by
| Status: | new → confirmed |
|---|
comment:4 Changed 10 years ago by
| Owner: | set to Szymon Cofalik |
|---|---|
| Status: | confirmed → assigned |
comment:5 Changed 10 years ago by
| Status: | assigned → review |
|---|
Updated tests pushed to branch:t/13655.
comment:6 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Fixed on master with git:a0c9b89. Your patch wasn't complete because it covered only the last TC, while there were two TCs failing. I updated the rest though.
Note: See
TracTickets for help on using
tickets.
That is because of these lines: https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/pastefromword/filter/default.js#L964-L965