Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13656 closed Task (fixed)

Review a revert done to yui-3.17.1-dom-screen-node-core*

Reported by: Olek Nowodziński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.5.4
Component: General Version: 4.5.3
Keywords: Cc:

Description

In git:de679b432f6 I reverted some changes done in #13265 because it caused problems in tests/core/dom/element/element (getDocumentPosition failed) in IE8. We must ensure that what I did is safe considering the scope of #13265.

Change History (3)

comment:1 Changed 4 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 4 years ago by Piotrek Koszuliński

Resolution: fixed
Status: assignedclosed

YUI is not developed any more, so it's about time to drop it also from our code base. Additionally, the whole TC was overcomplicated anyway, so I decided to simplify it. This way the tests will work fine via https.

Fixed with git:b12698b.

comment:3 Changed 4 years ago by Olek Nowodziński

I think it was a good decision. Good job.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy