Opened 4 years ago

Last modified 3 years ago

#13778 review Bug

[Chrome] Trying to insert a block before a block widget fails with an error

Reported by: Piotrek Koszuliński Owned by: Tade0
Priority: Nice to have (we want to work on it) Milestone:
Component: General Version: 4.3
Keywords: Cc:

Description

Steps to reproduce

  1. http://jsfiddle.net/HugeHugh/3xu8yece/
  2. Try to insert the horizontal line without focusing the editor first.

Expected result

It's inserted before the widget.

Actual result

An error is thrown.

Other details (browser, OS, CKEditor version, installed plugins)

I could not reproduce this issue on Firefox, so I guess it's related to Chrome's limited selection system which does not allow us to place selection before a non-editable block if it's the first descendant of the editable.

Attachments (1)

mytest.html (2.8 KB) - added by Jakub Ś 4 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 4 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:2 Changed 4 years ago by Hugh

Inquire about status of this ticket. It is important to me.

Discussion in related ticket is here: http://dev.ckeditor.com/ticket/13749

Your help is greatly appreciated.

Changed 4 years ago by Jakub Ś

Attachment: mytest.html added

comment:3 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.6

Let's see if we can solve it in 4.5.6.

comment:4 Changed 4 years ago by Tade0

Owner: set to Tade0
Status: confirmedassigned

comment:5 Changed 4 years ago by Tade0

Status: assignedreview

The previous method of ensuring that a range to which the element should've been inserted existed was not robust enough. Fixed that by creating a range when none is available.

Changes pushed to branch:t/13778.

comment:6 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.6CKEditor 4.5.7

comment:7 Changed 4 years ago by Hugh

Greetings. I'm unsure how to test the code change. When I go to the referenced branch on Github (t/13778) I see there was a change made. However, I use a pre-packaged build of CKEditor that was created by your website, and I'm not sure how to bring this change into my build of CKEditor that I configured on your website.

Here's the direct link to my build config: http://ckeditor.com/builder/544a1d22c6dfe8e23af36b1eee82633d

I just need some help to get the bug fix from this ticket into my build so that our app will begin functioning correctly. We've been waiting for this to be fixed since I first reported it 9/16/2015. Thanks so much for your help!

comment:8 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.7CKEditor 4.5.8

comment:9 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.8CKEditor 4.5.9

comment:10 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.9CKEditor 4.5.10

comment:11 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.10CKEditor 4.5.11

Moving tickets to the next milestone.

comment:12 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.11CKEditor 4.6.1

comment:13 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.6.1CKEditor 4.6.2

Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.

comment:14 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.6.2
Priority: NormalNice to have (we want to work on it)

Moving to the nice to have list.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy