Opened 9 years ago
Last modified 8 years ago
#13798 review Bug
Changing paragraph format causes cursor to move on Firefox 41
| Reported by: | Vangelis | Owned by: | Tomasz Jakut |
|---|---|---|---|
| Priority: | Nice to have (we want to work on it) | Milestone: | |
| Component: | Core : Focus | Version: | |
| Keywords: | Firefox | Cc: |
Description
Steps to reproduce
- On the CKEditor Demo page, set the cursor anywhere in the middle of a heading.
- Press Enter.
- Change the paragraph format to Normal.
- Press Backspace.
Actual result
Cursor has moved to the end of the line.
Change History (19)
comment:1 Changed 9 years ago by
| Keywords: | Firefox added; firefox removed |
|---|---|
| Milestone: | → CKEditor 4.5.5 |
| Status: | new → confirmed |
comment:2 Changed 9 years ago by
| Owner: | set to Tomasz Jakut |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 9 years ago by
| Status: | assigned → review |
|---|
It seems that old fix for Webkit is also working in Gecko, so I've just switched it on in Firefox - pushed branch:t/13798
comment:4 Changed 9 years ago by
| Status: | review → review_failed |
|---|
This custom handling in fact deals with this issue. We'll have to put some extra attention to delete/backspacing in testing phase for FF.
The only problem is that tests can definitely be moved to editable component. tests/core/editable/keystrokes/keystrokes.js is a good match for js tests. As for MT it can remain in ticket directory, it's fine. Pushed minor changes to t/13798 branch.
comment:5 Changed 9 years ago by
| Status: | review_failed → review |
|---|
Moved tests to tests/core/editable/keystrokes/keystrokes.js & pushed branch:t/13798.
comment:6 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Merged to master with git:8565201.
comment:7 Changed 9 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
This ticket enables custom DEL/BACKSPACE handling in FF but does not activate proper tests (1, 2) which turn out to be mostly red.
comment:8 Changed 9 years ago by
As @a.nowodzinski points out we're not running all tests for commited part of code. Initially it was created for Chrome, and it got solid portion of tests.
See: https://github.com/ckeditor/ckeditor-dev/blob/870c1a2a7af6611e00d379bb470742021dac59f2/tests/core/editable/keystrokes/delbackspacequirks/expanded.js#L20 https://github.com/ckeditor/ckeditor-dev/blob/870c1a2a7af6611e00d379bb470742021dac59f2/tests/core/editable/keystrokes/delbackspacequirks/collapsed.js#L30
Currently many of them are failing, it might be due to bogus BR, but we have to little time to verify it, so this merge will be reverted and resolved in next milestone.
comment:9 Changed 9 years ago by
| Milestone: | CKEditor 4.5.5 → CKEditor 4.5.6 |
|---|
I reverted git:fc399b7 from master. Re-attaching to the next milestone.
comment:10 Changed 9 years ago by
| Status: | reopened → confirmed |
|---|
comment:11 Changed 9 years ago by
| Status: | confirmed → review |
|---|
The tests were failing due to bogus br. I've updated them & pushed branch:t/13798.
comment:12 Changed 9 years ago by
| Milestone: | CKEditor 4.5.6 → CKEditor 4.5.7 |
|---|
comment:13 Changed 9 years ago by
| Milestone: | CKEditor 4.5.7 → CKEditor 4.5.8 |
|---|
comment:14 Changed 9 years ago by
| Milestone: | CKEditor 4.5.8 → CKEditor 4.5.9 |
|---|
comment:15 Changed 8 years ago by
| Milestone: | CKEditor 4.5.9 → CKEditor 4.5.10 |
|---|
comment:16 Changed 8 years ago by
| Milestone: | CKEditor 4.5.10 → CKEditor 4.5.11 |
|---|
Moving tickets to the next milestone.
comment:17 Changed 8 years ago by
| Milestone: | CKEditor 4.5.11 → CKEditor 4.6.1 |
|---|
comment:18 Changed 8 years ago by
| Milestone: | CKEditor 4.6.1 → CKEditor 4.6.2 |
|---|
Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.
comment:19 Changed 8 years ago by
| Milestone: | CKEditor 4.6.2 |
|---|---|
| Priority: | Normal → Nice to have (we want to work on it) |
I can confirm it. It can be reproduced in FF 41 (but also FF 37) and in CKE 4.5.4 (but also 4.5.0). So it does not seem to be a recent regression in either CKEditor or FF.