Opened 12 years ago

Closed 12 years ago

#1381 closed Bug (fixed)

editor fails to load with 2.4.3 config file

Reported by: Alfonso Martínez de Lizarrondo Owned by:
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Cc:

Description

Yes, it's foolish, but we know that people don't read docs, so I've tried to place the fckconfig.js file from 2.4.3 in the SVN and it failed the first time in fcktoolbarfontformatcombo.js line 75 as it returns null for the style object.

Maybe putting a check there and an alert box "Read the upgrade guide" is enough (or even directly loading the page in a new window) and the rest of the configuration changes will be done properly.

Maybe we could check also what happens if there are extra commas or things like that.

Change History (1)

comment:1 Changed 12 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: newclosed

For now, we can hardcode messages like "The FCKConfig.SomeSetting setting was not found. Please check the fckconfig.js file", which would at least address developers to that file. I've implemented it with [1007].

It would be wonderful if we could do configurations validation, but this would impact in the editor code size. To avoid overloading the code, we are not making configuration checks. So, with the above changes, the editor will load, but will not be properly functional.

This is a problem we always had. The conceptions I have for the configuration system for version 3 would help us avoiding such problems. I think we should have a standard configurations set, compressed with the core code, which would them be overloaded by customized settings. In this way we would at least avoid having missing configurations, making also the maintenance a bit simpler.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy