Read-only mode allows cut

[egli]

Steps to reproduce

1. Load CKEditor read-only, ​http://ckeditor.com/demo#read-only
2. Select text
3. Ctrl-X or Command-X
4. Ctrl-Z or Command-Z

Expected result

1. During cut, nothing should happen, or text should be placed on clipboard without being removed.
2. Undo should have no effect.

Actual result

1. Cut removes text and puts in on the clipboard.
2. Undo exits out of read-only mode.

Other details (browser, OS, CKEditor version, installed plugins)

Tested on Chrome/Linux, Chrome/Mac, Safari/Mac.

[egli]

Actually, this seems to be Chrome only, and does not affect undo. I had loaded the wrong demo when testing against Safari.

[Jakub Ś]

Problem can be reproduced from CKEditor 4.5.0 in all browsers.

[Tomasz Jakut]

There was missing check in clipboard plugin if the editor is in read-only mode. Pushed fix to ​branch:t/13872

[Marek Lewandowski]

1. Now CKEDITOR.plugins.clipboard.initPasteDataTransfer will be called no matter what, resulting with changing your clippboard buffer if you'll do cut in readOnly mode.

The reason for that is that you're checking wrong event property evt.type where it should be evt.name. I've found this one out while adding new tests.

1. If I'm not mistaken ​this condition can be _shortened_ down to:

if ( !editor.readOnly || evt.name != 'cut' ) {

I've emphasized shortened, because I can't tell if it's equally easy to understand at first glance. We should go with easier to understand one, it's up to you to pick easier one.

1. Please update manual tests accordiginly for testser also to ensure that nothing got copied to the clipboard.

I've pushed some my changes to ​branch:t/13872, make sure to pull them.

[Tomasz Jakut]

1, 2. Yes, you're right.

3. Updated.

I also updated unit tests because they were failing in IE. Pushed changes to ​branch:t/13872.

[Marek Lewandowski]

Merged to master with ​git:48311f8.