Opened 3 years ago

Closed 3 years ago

#13887 closed Bug (fixed)

Target attribute value is altered when using edit link

Reported by: Sam Owned by:
Priority: Normal Milestone: CKEditor 4.5.5
Component: UI : Dialogs Version: 4.5.5
Keywords: Cc: byran.zaugg@…

Description

Steps to reproduce

  1. Create a new hyperlink
  2. Toggle the editor to show the source
  3. Add a target attribute to the a tag with something like "sso-link" as the value
  4. Toggle the editor to not show the source
  5. Right click the hyper link and select 'Edit Link'
  6. Save the link, there is no need to change anything
  7. Toggle the editor to show the source again

Expected result

The value of the target attribute will not have changed

Actual result

The value of the target attribute has changed from "sso-link" to "ssolink"

Other details (browser, OS, CKEditor version, installed plugins)

According to w3.org the target attribute should be allowed any valid browser context name, which is any string that is ASCII.

The code change that caused this was implemented to fix an IE bug onticket 5278 however it was a little to aggressive with removing invalid characters.

Change History (3)

comment:1 Changed 3 years ago by Byran Zaugg

Cc: byran.zaugg@… added

comment:2 Changed 3 years ago by Marek Lewandowski

Status: newconfirmed

comment:3 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.5
Resolution: fixed
Status: confirmedclosed

PR merged in git:ac399b8, thanks!

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy