Opened 9 years ago
Closed 9 years ago
#13916 closed Bug (fixed)
[IE9] tests/core/selection/fake test is not passing on IE9 when console window is opened.
Reported by: | Szymon Kupś | Owned by: | Szymon Kupś |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.5.7 |
Component: | General | Version: | 4.5.4 |
Keywords: | IE9 | Cc: |
Description (last modified by )
Run: http://test.ckedtior.dev:1030/tests/core/selection/fake
Test Fake-selection bookmark mark as not faked when no enclosed node found. (#13280)
is not passing when console window is opened.
This is caused (probably) by this code:
if ( window.console ) { // Override to avoid logging the CKE's warning about selection not being fake any more, // so the console stays clean when the test passes. var consoleLogSpy = sinon.stub( window.console, 'log' ); }
When console is opened we try to stub console.log method but sinon library fails on native IE9 implementation and throws an error Attempted to wrap object property log as function
. Similar problem: #13917.
Change History (5)
comment:1 Changed 9 years ago by
Owner: | set to Szymon Kupś |
---|---|
Status: | new → assigned |
comment:2 Changed 9 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 9 years ago by
Status: | assigned → review |
---|
comment:4 Changed 9 years ago by
Milestone: | CKEditor 4.5.6 → CKEditor 4.5.7 |
---|
comment:5 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Fixed with git:26a9fb2c6f (merged to master).
Pushed branch:t/13916. On IE <= 9 sinon library has problems with stubbing
window.console
functions.selectBookmarks
function is usingCKEDITOR.warn
method now, so it can be used for stub instead ofconsole.log
(which is executed beneath).