Opened 4 years ago

Closed 4 years ago

#13916 closed Bug (fixed)

[IE9] tests/core/selection/fake test is not passing on IE9 when console window is opened.

Reported by: Szymon Kupś Owned by: Szymon Kupś
Priority: Normal Milestone: CKEditor 4.5.7
Component: General Version: 4.5.4
Keywords: IE9 Cc:

Description (last modified by Szymon Kupś)

Run: http://test.ckedtior.dev:1030/tests/core/selection/fake Test Fake-selection bookmark mark as not faked when no enclosed node found. (#13280) is not passing when console window is opened.

This is caused (probably) by this code:

if ( window.console ) {
	// Override to avoid logging the CKE's warning about selection not being fake any more,
	// so the console stays clean when the test passes.
	var consoleLogSpy = sinon.stub( window.console, 'log' );
}

When console is opened we try to stub console.log method but sinon library fails on native IE9 implementation and throws an error Attempted to wrap object property log as function. Similar problem: #13917.

Change History (5)

comment:1 Changed 4 years ago by Szymon Kupś

Owner: set to Szymon Kupś
Status: newassigned

comment:2 Changed 4 years ago by Szymon Kupś

Description: modified (diff)

comment:3 Changed 4 years ago by Szymon Kupś

Status: assignedreview

Pushed branch:t/13916. On IE <= 9 sinon library has problems with stubbing window.console functions. selectBookmarks function is using CKEDITOR.warn method now, so it can be used for stub instead of console.log (which is executed beneath).

comment:4 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.6CKEditor 4.5.7

comment:5 Changed 4 years ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed

Fixed with git:26a9fb2c6f (merged to master).

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy