Opened 4 years ago

Closed 3 years ago

#13917 closed Bug (fixed)

[IE9] tests/core/log tests are not passing on IE9 when console window is opened.

Reported by: Szymon Kupś Owned by: Szymon Kupś
Priority: Normal Milestone: CKEditor 4.5.7
Component: General Version: 4.5.4
Keywords: IE9 Cc:

Description

Run: http://test.ckedtior.dev:1030/tests/core/log on IE9 when console window is open. Tests are not passing with Object doesn't support this action message. It looks like this started to happen after upgrading to new benderjs-sinon version.

After short research I can say that this is connected with spying on native console object.

Change History (5)

comment:1 Changed 4 years ago by Szymon Kupś

Owner: set to Szymon Kupś
Status: newassigned

comment:2 Changed 4 years ago by Szymon Kupś

Summary: [IE9] tests/core/selection/log tests are not passing on IE9 when console window is opened.[IE9] tests/core/log tests are not passing on IE9 when console window is opened.

comment:3 Changed 4 years ago by Szymon Kupś

Status: assignedreview

Pushed branch:t/13917. For browsers <= IE9 we need to stub whole windows.console object to make sinon.stub() work correctly.

comment:4 Changed 4 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.6CKEditor 4.5.7

comment:5 Changed 3 years ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed

Great! Fixed with git:8761a511b9 (merged to master).

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy