Opened 3 years ago

Closed 3 years ago

#13921 closed Bug (worksforme)

[Edge] image2/editing test works unstable

Reported by: Szymon Kupś Owned by: Tomasz Jakut
Priority: Normal Milestone:
Component: General Version: 4.5.4
Keywords: Cc:

Description

Run: htttp://tests.ckeditor.dev:1030/tests/plugins/image2/editing

Last test of the suite test dimension should be empty after resetting size and loading image works very unstable in Edge.

Change History (13)

comment:1 Changed 3 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 3 years ago by Tomasz Jakut

Owner: set to Tomasz Jakut
Status: confirmedassigned

comment:3 Changed 3 years ago by Tomasz Jakut

Status: assignedreview

Honestly I find the stability of this test in Edge quite good. But some more waiting seems to improve it. In addition I added code to hide the dialog after this test. Pushed branch:t/13921.

comment:4 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.6CKEditor 4.5.7

comment:5 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.7CKEditor 4.5.8

comment:6 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.8CKEditor 4.5.9

comment:7 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.9CKEditor 4.5.8

comment:8 Changed 3 years ago by Marek Lewandowski

@Tade0 I'll ask you to review this one.

comment:9 Changed 3 years ago by Tade0

Here's a summary of the information I gathered:

  • Current master - passing, stable.
  • After fix - passing, stable.

The MS site with VM links says, that the build number for Win10 VM is 20150801 which, according to this ticket: https://connect.microsoft.com/IE/feedback/details/1748661/edge-vm-has-incorrect-user-agent-string Corresponds to Edge build 12.10136.

For some magic reason(probably Insider Program) my Edge version is 12.10525.

Bottom line: This test should pass and be stable, but if our only downloadable version of Edge is 12.10136, then this might be a headache.

comment:10 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.8CKEditor 4.5.9

I had a different experience. My VM sticks to some ancient 20.10240.16384.0 version, and I can't force it to update it (I even downloaded most recent image from Modern IE). It has a prolem with stability in this test.

However on a desktop I have 25.10586.0.0 and it's working fine there. Tade0 was able to get a more recent version and it doesn't seem to cause the issue.

I'm moving it to 4.5.9 and we'll see if Modern IE image will be updated by that time.

comment:11 Changed 3 years ago by Marek Lewandowski

Milestone: CKEditor 4.5.9CKEditor 4.5.10

comment:12 Changed 3 years ago by Tade0

I tried this on the VM with Edge updated to 25.10586.0.0 and everything is working fine.

At the first run of Bender on that VM this particular test failed, so there's probably some race condition, but subsequent runs were all consistently green.

comment:13 Changed 3 years ago by Tade0

Milestone: CKEditor 4.5.10
Resolution: worksforme
Status: reviewclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy