Opened 17 years ago
Closed 17 years ago
#1411 closed Bug (fixed)
Simple form of combo controls show improper (enabled) state when viewing HTML code
| Reported by: | Mark Bryson | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6 |
| Component: | UI : Toolbar | Version: | FCKeditor 2.4.3 |
| Keywords: | Review+ | Cc: |
Description
This is true in both 2.4.3 and 2.5.beta when using IE7 (other browsers not tested). When FCK_TOOLBARITEM_ONLYTEXT is used for anything derived from FCKToolbarSpecialCombo; the state of the control will not be shown in the grayed out disabled state when in Source View mode. (Can be duplicated in 6th example for plugins) I think this is really a flaw in whatever skin is being used. If you find the line (412 if default skin) in the 'fck_editor.css' file of the skin that looks like:
.SC_FieldDisabled .SC_FieldButton, .SC_FieldDisabled .SC_FieldCaption
and change it to:
.SC_FieldDisabled .SC_FieldButton, .SC_FieldDisabled .SC_FieldCaption, .SC_FieldDisabled
That fixes it for me.
Attachments (1)
Change History (5)
Changed 17 years ago by
| Attachment: | 1411.patch added |
|---|
comment:1 Changed 17 years ago by
| Keywords: | HasPatch added |
|---|---|
| Milestone: | FCKeditor 2.5 → FCKeditor 2.6 |
| Version: | FCKeditor 2.5 Beta → FCKeditor 2.4.3 |
The proposed fix breaks the combos in normal mode instead. I've attached a patch for it.
As we are working to stabilize the 2.5 Beta, I'm targeting it to the 2.6 to avoid undesired surprises.
comment:2 Changed 17 years ago by
| Keywords: | Review? added; HasPatch removed |
|---|
comment:3 Changed 17 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:4 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed with [1715]. Click here for more info about our SVN system.
Proposal patch