Opened 4 years ago

Closed 3 years ago

#14417 closed New Feature (invalid)

Missing functionality to pass custom title attribute when using menugroups

Reported by: Radoslav Petkov Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

Hello,

I need the option to pass the title of the menu created by the menubutton. Currently all such menus has title's value editor.lang.common.options.

Here is the source code: https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/menubutton/plugin.js#L26

I am using the following functions: editor.addMenuGroup(menuGroup); editor.ui.add('Button', CKEDITOR.UI_MENUBUTTON ...

Is there way to pass it from the outside? If not please make sure to include it in the feature releases or tell me what is the workflow to contribute this implementation?

I look forward to receiving your reply. Thank you in advance!

Change History (1)

comment:1 Changed 3 years ago by Jakub Ś

Keywords: menubutton menu title config removed
Resolution: invalid
Status: newclosed
Version: 4.5.7

There is a method addMenuGroup available for menubotton - https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/menu/plugin.js#L26-L28 and some menubutton plugins use it e.g. https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/language/plugin.js#L94-L95

https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/menubutton/plugin.js#L29

The attribute which you are refering to is used as a general container for groups. While groups are added to particular menu items in css classes e.g. cke_menubutton__language_remove

Please also see attached image.


As you can see there is single div container so even if it was possible to specify something else than Options then it wouldn't work as expected in case of having more than one group.
Each group in menubutton is separated by a horizontal line so there is no problem distinguishing them.
Items are not help in container like div but it is possible to get them all by searching by css class.


I will close this ticket because I don’t think it is valid but if you don’t agree, please leave a comment explaining why you don’t agree.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy