New Balloon Panel plugin

[Anna Tomanek]

The ​Balloon Panel plugin used by Accessibility Checker needs to be added to CKEditor core repository. It will be available as an official optional plugin, under the same licenses as CKEditor.

Things to check:

1. Code quality.
2. Test coverage.
3. License and copyright headers.
4. API docs.
5. Language strings (if any).
6. Manual test.
7. Move active balloonpanel issues to Trac.

[Anna Tomanek]

License, copyright headers, API docs corrected in GH.

[Marek Lewandowski]

We need couple more things: manual test, SDK sample and we need to remember to move open balloonpanel issues to Trac.

[Anna Tomanek]

Re SDK sample - we agreed it would be a nice idea, but it's not a priority and we need to have a really interesting use case to show how Balloon Panel can be used without AC and still impress the developers.

[Marek Lewandowski]

SDK sample extracted to issue #14520.

[Tade0]

Done so far:

1. Plugin added to CKE repo.
2. Corrected some minor style errors.
3. Created manual test.

[Marek Lewandowski]

Pushed couple of minor changes.

• We need also to provide a skin for kama.
• In dev sample close button does not work, let's fix it. Is it the issue of sample, or the balloon plugin itself? I believe it's the later.
• We need to create a general manual test for balloonpanel. I recall there was an issue with body margin, I think it could be easily solved by overriding bender styles in manual test HTML file with a stylesheet element.

[Tade0]

Added a manual test that should be flexible enough to test most cases.

Changes pushed to ​branch:t/14449.

[Marek Lewandowski]

1. Restructured test steps in panel.md test.
2. panel.md:

Manual test: ​http://tests.ckeditor.dev:1030/tests/plugins/balloonpanel/manual/panel

The panel should move when the editor is scrolled so that it always points at "Test L".

Fails.

The panel should stay (when it's possible) within the viewport and the editor area.

Fails. There's actually no convienient way to test it, the content is not as high that you could make "Test L" go out of the border of ther editor. I've tested it simply by setting editor height to 300.

1. balloonpanel.md let's reduce plugin amount
2. balloonpanel.md - Please simplify the process, just show the balloonpanel when tester clicks any <strong>. This TC must be as simple as possible.
3. We no longer need ​dev sample, since we have manual test.

[Tade0]

Simplified manual tests as requested in comment:13. Deleted dev sample.

Note: the features described in panel.md don't seem to be implemented at the moment.

[Marek Lewandowski]

• 2/3 of balloonpanel test suites are failing: ​http://tests.ckeditor.dev:1030/#tests/is:unit,path:/tests/plugins/balloonpanel

• We need also to provide a skin for kama

There's still no skin for kama.

Please provide fixes asap, let me know if you need any information.

[Tade0]

Fixed.

Changes pushed to ​branch:t/14449.

[Marek Lewandowski]

Fixed with ​git:8ab1a8202c (merged to major).