Opened 4 years ago

Last modified 4 years ago

#14562 review Bug

triple click and delete ruins widget in chrome

Reported by: bwaindwain Owned by: Tade0
Priority: Normal Milestone:
Component: UI : Widgets Version: 4.3
Keywords: Blink Cc:

Description

Steps to reproduce

  1. Use chrome
  2. insert widget with two editable regions that are both div
  3. type some text in first region
  4. triple click in first region (to select entire block)
  5. press delete or backspace key

See http://jsfiddle.net/dbz3gqLe/

Expected result

text should be deleted and the widget should still have two editable regions

Actual result

In CKEditor 4.5.8, the entire first region is deleted.

In CKEditor 4.4.1, the text from second region is moved to the first. See http://jsfiddle.net/o34t8zbk/

Other details (browser, OS, CKEditor version, installed plugins)

chrome 49.0.0263

See Also

http://dev.ckeditor.com/ticket/14353 http://dev.ckeditor.com/ticket/14354 http://dev.ckeditor.com/ticket/12677 http://dev.ckeditor.com/ticket/13395

Change History (5)

comment:1 Changed 4 years ago by Jakub Ś

Keywords: Blink added; widget removed
Status: newconfirmed
Version: 4.5.84.3

Seems we are not handling triple-click in this special case for Blink.

  1. I have tried reproducing this problem in our standard simple box but I only got content being moved from editable two to editable one. This is also an error.
  2. I have then modified simplebox and changed h2 to div and got result described in TC starting from CKEditor 4.4.2. Before that version (starting from 4.3.0), content from editable one is moved to editable two.

comment:2 Changed 4 years ago by Tade0

Owner: set to Tade0
Status: confirmedassigned

comment:3 Changed 4 years ago by Tade0

What I've established so far is that on triple-click the created selection starts at the beginning of the text, but seems to end after the second div.

@bwaindwain Thank you for delivering such a high quality bug report.

comment:5 Changed 4 years ago by Tade0

Status: assignedreview

I devised a solution that works in this particular case(selection crossing editable boundaries on backspace/delete).

Ideally we would want to correct the selection on selection change, but initial trials show, that the appropriate event is not fired(to investigate).

@bwaindwain I took the liberty of creating a manual test based on your jsFiddle example.

Changes pushed to branch:t/14562.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy