Opened 10 years ago

Closed 9 years ago

#1502 closed Bug (fixed)

Remove format doesn't remove attributes

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6
Component: Core : Styles Version: FCKeditor 2.5 Beta
Keywords: Confirmed Review+ Cc:

Description

The "Remove format" introduced in #75 doesn't remove any attribute, so it leaves the class and styles, so in the end the result is almost no clean up at all.

This is a list of attributes that should be cleaned at least to have some clean output:

  • class / className
  • style
  • lang
  • width
  • height
  • align
  • v:shapes
  • x:str
  • x:num
  • hspace
  • valign

Attachments (2)

1502.patch (1.8 KB) - added by Alfonso Martínez de Lizarrondo 9 years ago.
Proposed SVN patch
1502_2.patch (3.1 KB) - added by Alfonso Martínez de Lizarrondo 9 years ago.
Revised patch

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by Wojciech Olchawa

Keywords: Confirmed added

Confirmed in IE and FF2 using version 2.5 SVN Build 18185

Changed 9 years ago by Alfonso Martínez de Lizarrondo

Attachment: 1502.patch added

Proposed SVN patch

comment:2 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

The patch does take care of removing that list of attributes (it's configurable in fckconfig.js) when the remove Format is executed, so the output code is really clean.

Changed 9 years ago by Alfonso Martínez de Lizarrondo

Attachment: 1502_2.patch added

Revised patch

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:4 Changed 9 years ago by Alfonso Martínez de Lizarrondo

Milestone: FCKeditor 2.6
Resolution: fixed
Status: assignedclosed

Fixed with [1603]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy