Opened 12 years ago

Closed 11 years ago

#1576 closed Bug (worksforme)

Editor height is always =300px

Reported by: B_aniaczek Owned by:
Priority: Normal Milestone:
Component: Project : MediaWiki+FCKeditor Version: SVN (FCKeditor) - Retired
Keywords: Pending WorksForMe HasPatch Cc:

Description

MediaWiki 1.11.0, browsers: FireFox 2.0, MSIE 7.0

Editor height is always set to 300. Proposition: In file FCKeditor/FCKeditor.body.php replace lines

function onLoadFCKeditor()
[...]
height = ( !height || height < 300 ) ? 300 : height ;

with code:

function onLoadFCKeditor() {

 var box = document.getElementById('wpTextbox1');
 if ( box ) {

  var height = $wgFCKEditorHeight ;
  if ( height == 0 ) {

   height = box.offsetHeight;
   var tBar = document.getElementById('toolbar');
   if ( tBar )
    height += tBar.offsetHeight;
   height += 1;

   if ( ! height ) {
    var aTop = tBar;
    if ( ! aTop )
     aTop = box;
    var aBottom = document.getElementById('editpage-copywarn');

    if ( aTop && aBottom )
     height = aBottom.offsetTop - aTop.offsetTop - 6;
   }
  }

  // Enforce a minimum height.
  height = ( !height || height < 300 ) ? 300 : height ;

Change History (3)

comment:1 Changed 12 years ago by Wojciech Olchawa

Keywords: HasPatch added
Version: SVN

comment:2 Changed 11 years ago by Wiktor Walc

Keywords: Pending WorksForMe added

I tried to reproduce it on IE6/IE7/FF 2.0.0.13 + MediaWiki 1.12.0/1.11.1 + FCKeditor 2.5.1.

FCKeditor height was set automatically to fit the page (much more than 300px), could you confirm that this problem doesn't exist anymore?

comment:3 Changed 11 years ago by Frederico Caldeira Knabben

Resolution: worksforme
Status: newclosed

Expired.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy