Opened 13 years ago

Closed 13 years ago

#16 closed Task (fixed)

Updating public bugs when they are fixed in private SVN

Reported by: Alfonso Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

I've committed two fixes to the SVN to avoid an error in Firefox 3 and some warnings based on the public bugs and patches available. (I hope that everything is alright)

https://sourceforge.net/tracker/index.php?func=detail&aid=1604576&group_id=75348&atid=543655
https://sourceforge.net/tracker/index.php?func=detail&aid=1577247&group_id=75348&atid=543653

and the new sample file
https://sourceforge.net/tracker/index.php?func=detail&aid=1456343&group_id=75348&atid=543655

The question is: when should the public bugs be marked as fixed? now in order to avoid that we forget about them or latter when the public SVN is updated?

There are also two other bugs that it seems that should be fixed in SVN but they aren't closed:
buttons in modal dialog IE (SVN)
https://sourceforge.net/tracker/index.php?func=detail&aid=1199014&group_id=75348&atid=543653
https://sourceforge.net/tracker/index.php?func=detail&aid=1208960&group_id=75348&atid=543653

is this fixed also?
https://sourceforge.net/tracker/index.php?func=detail&aid=1490615&group_id=75348&atid=543653

Change History (3)

comment:1 Changed 13 years ago by Frederico Caldeira Knabben

We should close bugs in SF only when the fix is already available in the public SVN. So, if we have internal tickets related to them, we could just add a comment regarding the fix and wait to close it here, to avoid forgetting to close the public tickets. Once the public SVN is updated and the SF bugs are closed, we proceed on closing things here too.

Actually it would not be a problem to commit things to the public SVN everyday (I've done it until now). I'm just waiting to do that to have the Enter Key Handler (EK) more stable and tested, mainly over IE. This is the big problem of working directly in the "trunk" instead of having specialized branches. As I've said, we'll start using branches after the 2.4.

Should we concentrate the responsibility of public commits to a single person?

Also, I've already committed a first version of the EK for IE to the SVN. Any help on testing and opening tickets for it is welcome.

I've closed the three bugs related to the modal dialog problem with IE.

Thanks again.

comment:2 Changed 13 years ago by Frederico Caldeira Knabben

I've just committed the current dev trunk to the public SVN. Any pending bug can be closed (using the specific canned response at SF).

Thanks again.

comment:3 Changed 13 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: newclosed

All reports have been closed. Thanks Alfonso.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy