Opened 10 years ago

Closed 10 years ago

#16383 closed Bug (fixed)

Strikethrough button is invalid in Moono-lisa

Reported by: Wiktor Walc Owned by: kkrzton
Priority: Normal Milestone: CKEditor 4.6.0
Component: UI : Toolbar Version:
Keywords: Cc:

Description (last modified by Wiktor Walc)

Actual result

Attachments (2)

strikethrough.png (5.2 KB) - added by Wiktor Walc 10 years ago.
icons32.svg (132.4 KB) - added by kkrzton 10 years ago.
The .svg with fixed icon is already provided.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by Wiktor Walc

Attachment: strikethrough.png added

comment:1 Changed 10 years ago by Wiktor Walc

Description: modified (diff)

comment:2 Changed 10 years ago by Wiktor Walc

Status: newconfirmed

comment:3 Changed 10 years ago by Wiktor Walc

Note: most likely hidpi icons only have this problem.

Changed 10 years ago by kkrzton

Attachment: icons32.svg added

The .svg with fixed icon is already provided.

comment:4 Changed 10 years ago by Marek Lewandowski

Owner: set to Marek Lewandowski
Status: confirmedassigned

comment:5 Changed 10 years ago by Marek Lewandowski

Owner: Marek Lewandowski deleted
Status: assignedconfirmed

Unfortunately it turns that tools used by: node ./dev/iconmaker/iconmaker.js -i skins/moono/dev/icons16.svg -l skins/moono/dev/locations.json [iconfile, icons locations]

command are broken on Windows (produces red images)

comment:6 Changed 10 years ago by kkrzton

Owner: set to kkrzton
Status: confirmedreview

On OS X it also does not look good when generated from .svg so the icons should be generated from .png file (I think that is the intention of the iconmaker tool).

Pushed new files and regenerated icons to t/16383.

comment:7 Changed 10 years ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed

Fixed with git:0d69bac, merged to major.

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy