Opened 8 years ago
Closed 8 years ago
#16593 closed Bug (fixed)
IE11 regular pasting doesn't work
Reported by: | Marek Lewandowski | Owned by: | Marek Lewandowski |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.6.0 |
Component: | Plugin : Paste from Word | Version: | 4.6.0 |
Keywords: | Cc: |
Description (last modified by )
IE11 regular pasting doesn't work
- Open an editor instance with new
pastefromword
implementation in IE11. - Set the content using source button to the following:
<h1>Hello world!</h1> <ol> <li>dsa</li> </ol> <p>I'm an instance of <a href="http://ckeditor.com">CKEditor</a>.</p>
- Press ctrl + x.
- Press ctrl + v.
Expected result
Content gets pasted.
Actual result
Nothing happens.
Important notes
It happens only on Windows 7 IE11 - I've tested it with Windows 10 IE11 and it's fine there.
Also the bug comes 100% from new PFW, as if you disable the plugin it works OK.
Change History (10)
comment:1 Changed 8 years ago by
Description: | modified (diff) |
---|---|
Status: | new → confirmed |
comment:2 Changed 8 years ago by
Owner: | set to Tade0 |
---|---|
Status: | confirmed → assigned |
comment:3 Changed 8 years ago by
Status: | assigned → review |
---|
comment:4 Changed 8 years ago by
I've pushed simple fix earlier in master. To ensure that it works as expected I've uploaded a manual test to be included during the release. See branch:t/16593b. R?
comment:5 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
LGTM merged with git:7d1ebbe.
comment:6 Changed 8 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Turned out that the issue was still present on major branch. Pushed new solution to branch:t/16593c.
comment:7 Changed 8 years ago by
Owner: | changed from Tade0 to Marek Lewandowski |
---|---|
Status: | reopened → review |
comment:8 Changed 8 years ago by
Status: | review → review_passed |
---|
This solution is a little bit dirty, but it should do.
I doubt there exists a general way to detect whether something was pasted from Word.
LGTM.
comment:9 Changed 8 years ago by
Yes, I found that mso-list is the main tell here. There's one global regexp match on each CKEDITOR.cleanWord
call for performance reason, you could do it for each ol / ul on innerHTML - but then the performance would be hurt, so that's the compromise.
I think that we could look at dissolveList
and make it a little smarter in upcoming releases, so it handles regular lists gracefully.
Fixed with git:a00236b.
comment:10 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Pushed possible solution to branch:t/16593.