Opened 3 years ago

Closed 3 years ago

#16593 closed Bug (fixed)

IE11 regular pasting doesn't work

Reported by: Marek Lewandowski Owned by: Marek Lewandowski
Priority: Normal Milestone: CKEditor 4.6.0
Component: Plugin : Paste from Word Version: 4.6.0
Keywords: Cc:

Description (last modified by Marek Lewandowski)

IE11 regular pasting doesn't work

  1. Open an editor instance with new pastefromword implementation in IE11.
  2. Set the content using source button to the following:
<h1>Hello world!</h1>

<ol>
	<li>dsa</li>
</ol>

<p>I&#39;m an instance of <a href="http://ckeditor.com">CKEditor</a>.</p>
  1. Press ctrl + x.
  2. Press ctrl + v.

Expected result

Content gets pasted.

Actual result

Nothing happens.

Important notes

It happens only on Windows 7 IE11 - I've tested it with Windows 10 IE11 and it's fine there.

Also the bug comes 100% from new PFW, as if you disable the plugin it works OK.

Change History (10)

comment:1 Changed 3 years ago by Marek Lewandowski

Description: modified (diff)
Status: newconfirmed

comment:2 Changed 3 years ago by Tade0

Owner: set to Tade0
Status: confirmedassigned

comment:3 Changed 3 years ago by Tade0

Status: assignedreview

Pushed possible solution to branch:t/16593.

comment:4 Changed 3 years ago by Marek Lewandowski

I've pushed simple fix earlier in master. To ensure that it works as expected I've uploaded a manual test to be included during the release. See branch:t/16593b. R?

comment:5 Changed 3 years ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed

LGTM merged with git:7d1ebbe.

comment:6 Changed 3 years ago by Marek Lewandowski

Resolution: fixed
Status: closedreopened

Turned out that the issue was still present on major branch. Pushed new solution to branch:t/16593c.

comment:7 Changed 3 years ago by Marek Lewandowski

Owner: changed from Tade0 to Marek Lewandowski
Status: reopenedreview

comment:8 Changed 3 years ago by Tade0

Status: reviewreview_passed

This solution is a little bit dirty, but it should do.

I doubt there exists a general way to detect whether something was pasted from Word.

LGTM.

comment:9 Changed 3 years ago by Marek Lewandowski

Yes, I found that mso-list is the main tell here. There's one global regexp match on each CKEDITOR.cleanWord call for performance reason, you could do it for each ol / ul on innerHTML - but then the performance would be hurt, so that's the compromise.

I think that we could look at dissolveList and make it a little smarter in upcoming releases, so it handles regular lists gracefully.

Fixed with git:a00236b.

comment:10 Changed 3 years ago by Marek Lewandowski

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy