#16860 closed Bug (fixed)

Paste from Word converts ordered lists too greedy

Reported by: Marek Lewandowski Owned by: Marek Lewandowski
Priority: Normal Milestone: CKEditor 4.7.0
Component: Plugin : Paste from Word Version: 4.7.0
Keywords: Cc:

Description (last modified by Marek Lewandowski)

Fixture for Ordered_list did not actually contain ordered list.

It was simply a set of paragraphs. Also it should not be converted to ordred list, since semanticaly these are just paragraphs.

Steps to reproduce

  1. Open linked docx in Word, copy all content to the clipbaord.
  2. Paste it into the CKEditor instance.

Expected result

Text is pasted as a set of paragraphs.

Actual result

Paragraphs are converted into ordered list.

Change History (8)

comment:1 Changed 18 months ago by Marek Lewandowski

Description: modified (diff)
Status: newconfirmed

comment:2 Changed 18 months ago by Marek Lewandowski

Owner: set to Marek Lewandowski
Status: confirmedassigned

comment:3 Changed 18 months ago by Marek Lewandowski

Just a note, I'm unable to create Safari fixture ATM, so we need make sure to do this later on.

comment:4 Changed 18 months ago by Marek Lewandowski

Status: assignedreview

I'll provide missing Safari fixture in ~1hr.

comment:5 Changed 18 months ago by Tade0

Status: reviewreview_passed

Overall LGTM.

There are two failing tests in: http://tests.ckeditor.dev:1030/tests/plugins/pastefromword/generated/heuristics in IE8 only, but they fail the same way on major and don't seem to be related with the changes introduced here.

There was one style error that slipped through, but I fixed that.

comment:6 Changed 18 months ago by Marek Lewandowski

Branch pushed, please review the changes.

comment:7 Changed 18 months ago by Marek Lewandowski

Status: review_passedreview

comment:8 Changed 18 months ago by Tade0

Resolution: fixed
Status: reviewclosed

One test suite was hanging in IE11 - fixed that.

Fixed with git:6543f0d84c4207f51959cb21ab7c9f1e3e92b4f2.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy