Opened 20 months ago

Last modified 16 months ago

#16865 confirmed Bug

Fonts setting should not be toggling options.

Reported by: Ron Yu Owned by:
Priority: Normal Milestone:
Component: Core : Styles Version: 4.0
Keywords: Cc:

Description

Steps to reproduce

  1. Change the font size for the first time it works correctly.
  2. But if select the same font size again, it will revert back to the original font size. The same for font style.
  3. This behavior doesn't conform to other main editors, and could bring problems.

Expected result

Please prevent revert font back to original font if select same font again.

Actual result

Resetting the font to original font if select font again.

Other details (browser, OS, CKEditor version, installed plugins)

Change History (6)

comment:1 Changed 20 months ago by Ron Yu

Besides inconformity to user habit, below is a known problem case.

  • When I have some existing text and I paste additional paragraphs after it, now selecting one font and style for all text only works the second time, because for the first selecting it just resets the previous text to default, the pasted text remains unchanged.

comment:2 Changed 20 months ago by Jakub Ś

Status: newconfirmed
Version: 4.5.04.0

The toggling nature of dropdown buttons has been a feature at least since CKEditor 3.0. I however agree that for the case where you have font in comic sans | plain text and you want to apply Comic Sans to all text, you will first need to disable Comic Sans and then apply it again. This is the room for improvement – if selection has not only text styled in Comic Sans then dropdown option should not be selected.

Last edited 19 months ago by Jakub Ś (previous) (diff)

comment:3 Changed 19 months ago by Jakub Ś

Resolution: duplicate
Status: confirmedclosed

It turns out this is a duplicate of #13553

comment:4 Changed 16 months ago by Marek Lewandowski

Resolution: duplicate
Status: closedreopened

@j.swiderski these are two different issues.

Issue #13553 says about dropdown in case of selection that is has a different value at the beginning and the end of selection, e.g. two different fonts.

This issue however is related to the fact that once having given value in a dropdown, say X, if you pick X again the feature will remove the style from editor, while here OP expects the option to be preserved.


Now, the current solution means like simple bold/underline features, meaning that if you press it while being active, it will remove the style. It works, but as mentioned this behavior is not interoperable with other editors.

I agree that this change make sense for a better conformance with a common editing experience. However it's a UX change that should be delivered with a major release.

Note that this has more implications: how one should remove font size markup? It requires to add something like <unset> position in the dropdown, which is also not an ideal solution.

comment:5 Changed 16 months ago by Jakub Ś

Status: reopenedconfirmed

@m.lewandowski you are right I got too quick closing this one.

comment:6 Changed 16 months ago by Marek Lewandowski

Meanwhile I have reported [the issue in our GitHub](https://github.com/ckeditor/ckeditor-dev/issues/584) so it can be discussed there. I made it a feature request though, as it's not a bug.

Last edited 16 months ago by Marek Lewandowski (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy