Opened 8 years ago
Closed 8 years ago
#16928 closed Task (fixed)
Bleeding tests
| Reported by: | Tomasz Jakut | Owned by: | Tomasz Jakut |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.7.0 |
| Component: | General | Version: | 4.7.0 |
| Keywords: | Cc: |
Description
During running unit tests in sequence there are some bleeding, but still passing ones:
resourcemanager.js:211 Uncaught Error: [CKEDITOR.resourceManager.load] Resource name "default" was not found at "http://tests.ckeditor.dev:1030/apps/ckeditor/styles.js"focusmanager.js:164 Uncaught TypeError: Cannot read property '$' of undefinedlang.js:54 Uncaught TypeError: Cannot set property 'dir' of undefined
These errors appear randomly, in different tests and don't show up if unit tests are run separately. Probably the issue is connected with the way in which Bender runs tests and causes that DOM is not always ready when the test runs.
Change History (6)
comment:1 Changed 8 years ago by
| Owner: | set to Tomasz Jakut |
|---|---|
| Status: | new → assigned |
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
| Status: | assigned → review |
|---|
The other errors were easily resolved using some async magic (I've added wait in 3 places). It's also worth noting that these tests were bleeding only when run from Bender Dashboard, run directly behaved correcly.
Pushed branch:t/16928.
comment:5 Changed 8 years ago by
| Milestone: | → CKEditor 4.7.0 |
|---|
comment:6 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with cf4eaff.
Note: See
TracTickets for help on using
tickets.
focusmanager.js:164 Uncaught TypeError: Cannot read property '$' of undefinedis caused by #16935.