[Chrome] Source mode in one editor raises error while focusing other editor

[Tomasz Jakut]

Steps to reproduce

1. Open ​https://jsfiddle.net/Comandeer/6333p40t/
2. Open console.
3. Click inside the first editor to focus it..
4. Switch the first editor to source mode.
5. Click inside the second editor to focus it.

Expected result

Second editor is focused.

Actual result

Second editor is focused, but at the same time error is thrown into console:

Uncaught TypeError: Cannot read property '$' of undefined

Other details (browser, OS, CKEditor version, installed plugins)

It seems that error is connected with the fix for #13446.

[Marek Lewandowski]

It might be related to #16825. Please see if reverting commit: ​https://github.com/ckeditor/ckeditor-dev/commit/2c0d9802bd809bb3c28c86ea8ff911f351d6ae18 fixes the problem.

[Tomasz Jakut]

The case could be even simplified:

1. Open ​https://jsfiddle.net/Comandeer/L82fagkp/
2. Click inside editor.
3. Click the button

Error is thrown. Seems that blurring editor in source mode causes the issue.

[Tomasz Jakut]

Reverting the change fixed the issue.

The issue is connected with the fact that editor.editable().isInline() always return true when classic editor is switched to source mode. Checking editor.elementMode on the other hand always refers to the WYSIWYG's mode editable.

I've added manual and unit tests. Pushed ​branch:t/16935.

[kkrzton]

LGTM!

[kkrzton]

Fixed with ​e1bf2df.